Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1259)

Issue 6858090: cert: fix expiry for non-UTC time zones

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rog
Modified:
11 years, 4 months ago
Reviewers:
mp+136722
Visibility:
Public.

Description

cert: fix expiry for non-UTC time zones A bug in the Go x509 package (fixed in tip) means that non-UTC time zones don't round-trip correctly. https://code.launchpad.net/~rogpeppe/juju-core/174-fix-cert-times/+merge/136722 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cert: fix expiry for non-UTC time zones #

Patch Set 3 : cert: fix expiry for non-UTC time zones #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cert/cert.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cert/cert_test.go View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 4 months ago (2012-11-28 17:11:44 UTC) #1
fwereade
LGTM
11 years, 4 months ago (2012-11-28 17:13:00 UTC) #2
rog
11 years, 4 months ago (2012-11-28 17:14:50 UTC) #3
*** Submitted:

cert: fix expiry for non-UTC time zones

A bug in the Go x509 package (fixed in tip)
means that non-UTC time zones don't round-trip
correctly.

R=fwereade
CC=
https://codereview.appspot.com/6858090
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b