Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 6858081: iam: added UserPolicy related methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by fss
Modified:
11 years, 1 month ago
Reviewers:
mp+136413
Visibility:
Public.

Description

iam: added UserPolicy related methods Now it's possible to Put, Delete and Retrieve a user policy. https://code.launchpad.net/~franciscosouza/goamz/iam-user-policy/+merge/136413 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : iam: added UserPolicy related methods #

Patch Set 3 : iam: added UserPolicy related methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -37 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M iam/iam.go View 1 2 3 chunks +96 lines, -0 lines 0 comments Download
M iam/iam_test.go View 1 2 2 chunks +53 lines, -0 lines 0 comments Download
M iam/iami_test.go View 1 2 2 chunks +33 lines, -0 lines 0 comments Download
M iam/iamtest/server.go View 1 2 5 chunks +125 lines, -37 lines 0 comments Download
M iam/responses_test.go View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7
fss
Please take a look.
11 years, 4 months ago (2012-11-27 13:38:51 UTC) #1
niemeyer
This looks great too. Only trivial style comments below. LGTM. Please ping for integration. https://codereview.appspot.com/6858081/diff/1/iam/iam_test.go ...
11 years, 1 month ago (2013-02-28 20:59:40 UTC) #2
fss
Please take a look. https://codereview.appspot.com/6858081/diff/1/iam/iam_test.go File iam/iam_test.go (right): https://codereview.appspot.com/6858081/diff/1/iam/iam_test.go#newcode109 iam/iam_test.go:109: "Statement": [ On 2013/02/28 20:59:40, ...
11 years, 1 month ago (2013-03-01 11:50:27 UTC) #3
fss
I will merge from trunk once 6855104 is merged in.
11 years, 1 month ago (2013-03-01 11:51:20 UTC) #4
niemeyer
The other branch was submitted.
11 years, 1 month ago (2013-03-01 18:25:04 UTC) #5
fss
Please take a look.
11 years, 1 month ago (2013-03-02 02:12:35 UTC) #6
niemeyer
11 years, 1 month ago (2013-03-02 02:56:43 UTC) #7
*** Submitted:

iam: added UserPolicy related methods

Now it's possible to Put, Delete and Retrieve a user policy.

R=niemeyer
CC=
https://codereview.appspot.com/6858081

https://codereview.appspot.com/6858081/diff/1/iam/iam.go
File iam/iam.go (right):

https://codereview.appspot.com/6858081/diff/1/iam/iam.go#newcode46
iam/iam.go:46: func (iam *IAM) postQuery(params map[string]string, resp
interface{}) error {
I'm integrating this, but in a follow up we should integrate this method with
query. I also think the > 200 test below and in the existing method isn't quite
right. It should test for 200, specifically, and other okay codes. This is a
problem we already have, though, so we can fix it in another branch.

Thanks for the changes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b