code review 6858063: goprotobuf: Update README install instructions for go1

goprotobuf: Update README install instructions for go1

[jmhodges, 2012-11-24 04:31:09]

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com, r@golang.org),

I'd like you to review this change to
https://code.google.com/p/goprotobuf

[jmhodges, 2012-11-24 04:35:49]

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com, r@golang.org),

Please take another look.

[dsymonds, 2012-11-25 22:41:36]

https://codereview.appspot.com/6858063/diff/7001/README
File README (right):

https://codereview.appspot.com/6858063/diff/7001/README#newcode49
README:49: The generated code can be compiled separately or as part of a normal
Go
drop this sentence; it's not a good idea to suggest.

[jmhodges, 2012-11-26 02:48:19]

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com, r@golang.org),

Please take another look.

[jmhodges, 2012-11-26 02:49:32]

On 2012/11/25 22:41:36, dsymonds wrote:
> https://codereview.appspot.com/6858063/diff/7001/README
> File README (right):
> 
> https://codereview.appspot.com/6858063/diff/7001/README#newcode49
> README:49: The generated code can be compiled separately or as part of a
normal
> Go
> drop this sentence; it's not a good idea to suggest.

Done. 

(Kind of curious which part you had problems with since it was there before this
patch.)

[dsymonds, 2012-11-26 02:55:18]

On Mon, Nov 26, 2012 at 1:49 PM,  <jeff@somethingsimilar.com> wrote:

> (Kind of curious which part you had problems with since it was there
> before this patch.)

The suggestion to build generated protobuf code into a package with
normal Go code is the bad part (and I realise it was there before).
It's a recipe for chaos, and the proto support library and code
generator assume that they are in full control over the package.

[dsymonds, 2012-11-26 02:55:35]

LGTM

[dsymonds, 2012-11-26 02:58:19]

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=29db96746e5d ***

goprotobuf: Update README install instructions for go1

R=dsymonds
CC=golang-dev, r
http://codereview.appspot.com/6858063

Committer: David Symonds <dsymonds@golang.org>