Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(327)

Issue 6858063: code review 6858063: goprotobuf: Update README install instructions for go1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by jmhodges
Modified:
9 years, 10 months ago
Reviewers:
CC:
dsymonds, golang-dev, r
Visibility:
Public.

Description

goprotobuf: Update README install instructions for go1

Patch Set 1 #

Patch Set 2 : diff -r b8402499e282 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r b8402499e282 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r b8402499e282 https://code.google.com/p/goprotobuf #

Total comments: 1

Patch Set 5 : diff -r b8402499e282 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M README View 1 2 3 4 1 chunk +7 lines, -12 lines 0 comments Download

Messages

Total messages: 8
jmhodges
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com, r@golang.org), I'd like you to review this change to https://code.google.com/p/goprotobuf
9 years, 10 months ago (2012-11-24 04:31:09 UTC) #1
jmhodges
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com, r@golang.org), Please take another look.
9 years, 10 months ago (2012-11-24 04:35:49 UTC) #2
dsymonds
https://codereview.appspot.com/6858063/diff/7001/README File README (right): https://codereview.appspot.com/6858063/diff/7001/README#newcode49 README:49: The generated code can be compiled separately or as ...
9 years, 10 months ago (2012-11-25 22:41:36 UTC) #3
jmhodges
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com, r@golang.org), Please take another look.
9 years, 10 months ago (2012-11-26 02:48:19 UTC) #4
jmhodges
On 2012/11/25 22:41:36, dsymonds wrote: > https://codereview.appspot.com/6858063/diff/7001/README > File README (right): > > https://codereview.appspot.com/6858063/diff/7001/README#newcode49 > ...
9 years, 10 months ago (2012-11-26 02:49:32 UTC) #5
dsymonds
On Mon, Nov 26, 2012 at 1:49 PM, <jeff@somethingsimilar.com> wrote: > (Kind of curious which ...
9 years, 10 months ago (2012-11-26 02:55:18 UTC) #6
dsymonds
LGTM
9 years, 10 months ago (2012-11-26 02:55:35 UTC) #7
dsymonds
9 years, 10 months ago (2012-11-26 02:58:19 UTC) #8
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=29db96746e5d ***

goprotobuf: Update README install instructions for go1

R=dsymonds
CC=golang-dev, r
http://codereview.appspot.com/6858063

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b