Issue 6858062: code review 6858062: io: SectionReader.ReadAt should return EOF when buf is ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6858062: code review 6858062: io: SectionReader.ReadAt should return EOF when buf is ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by minux1

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

io: SectionReader.ReadAt should return EOF when buf is not fully read Fixes issue 4392.

Patch Set 1 #

Patch Set 2 : diff -r 107e46216b58 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 107e46216b58 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3fe40a41018d https://code.google.com/p/go/ #

Patch Set 5 : diff -r 3fe40a41018d https://code.google.com/p/go/ #

Patch Set 6 : diff -r 3fe40a41018d https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	src/pkg/io/io.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/pkg/io/io_test.go	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

LGTM minux, looks like you forgot to hg mail this. (found via issue 4392)

12 years, 3 months ago (2012-12-09 18:14:28 UTC) #1

minux1

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2012-12-13 10:35:20 UTC) #2

minux1

12 years, 3 months ago (2012-12-13 10:36:43 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=8eab544488a8 ***

io: SectionReader.ReadAt should return EOF when buf is not fully read
Fixes issue 4392.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6858062

Expand All Messages | Collapse All Messages