Issue 68580043: code review 68580043: cmd/go: document new -exec flag on run/test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68580043: code review 68580043: cmd/go: document new -exec flag on run/test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rsc

Modified:
11 years, 2 months ago

Reviewers:
r, cookieo9

CC:
r, golang-codereviews

Visibility:
Public.

Description

cmd/go: document new -exec flag on run/test The new flag was added by CL 68150047 (part of the NaCl replay), but the change, like the original, omitted documentation of the new behavior.

Patch Set 2 : diff -r e77e74371f23 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e77e74371f23 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r e77e74371f23 https://code.google.com/p/go/ #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -7 lines)			Patch
M	doc/go1.3.txt	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/go/doc.go	View	1 2 3	5 chunks	+18 lines, -6 lines	1 comment	Download
M	src/cmd/go/run.go	View	1 2 3	1 chunk	+10 lines, -1 line	0 comments	Download
M	src/cmd/go/test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2014-02-25 15:13:55 UTC) #1

LGTM https://codereview.appspot.com/68580043/diff/40001/src/cmd/go/run.go File src/cmd/go/run.go (right): https://codereview.appspot.com/68580043/diff/40001/src/cmd/go/run.go#newcode44 src/cmd/go/run.go:44: like in 'go_nacl_386_exec a.out arguments...'. This allows execution ...

11 years, 2 months ago (2014-02-25 15:19:12 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=31fa9b3f70f7 *** cmd/go: document new -exec flag on run/test The new flag ...

11 years, 2 months ago (2014-02-25 15:22:30 UTC) #3

cookieo9

11 years, 2 months ago (2014-02-25 18:27:31 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/68580043/diff/50001/src/cmd/go/doc.go
File src/cmd/go/doc.go (left):

https://codereview.appspot.com/68580043/diff/50001/src/cmd/go/doc.go#oldcode481
src/cmd/go/doc.go:481: When either cgo or SWIG is used, go build will pass any
.c, .m, .s,
the ".m" clause is lost here.

Expand All Messages | Collapse All Messages