Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(885)

Issue 6856105: various: use TLS

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rog
Modified:
11 years, 4 months ago
Reviewers:
mp+136505
Visibility:
Public.

Description

various: use TLS This enables TLS for everything. https://code.launchpad.net/~rogpeppe/juju-core/170-use-tls/+merge/136505 Requires: https://code.launchpad.net/~rogpeppe/juju-core/171-cert-package/+merge/136497 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : various: use TLS #

Total comments: 7

Patch Set 3 : various: use TLS #

Total comments: 18

Patch Set 4 : various: use TLS #

Patch Set 5 : various: use TLS #

Patch Set 6 : various: use TLS #

Patch Set 7 : various: use TLS #

Patch Set 8 : various: use TLS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -894 lines) Patch
A [revision details] View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M container/container.go View 1 chunk +0 lines, -3 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 1 2 3 5 chunks +11 lines, -5 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M environs/config/authkeys.go View 1 2 3 2 chunks +5 lines, -16 lines 0 comments Download
M environs/ec2/ec2.go View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M environs/ec2/export_test.go View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M environs/ec2/live_test.go View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M juju/conn.go View 1 2 3 3 chunks +16 lines, -1 line 0 comments Download
M state/open.go View 1 2 3 5 chunks +30 lines, -25 lines 0 comments Download
M state/settings_test.go View 3 chunks +13 lines, -0 lines 0 comments Download
D state/ssh.go View 1 chunk +0 lines, -276 lines 0 comments Download
D state/ssh_test.go View 1 chunk +0 lines, -542 lines 0 comments Download
M state/state.go View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M testing/cert.go View 1 2 3 3 chunks +5 lines, -19 lines 0 comments Download
M testing/mgo.go View 1 2 3 3 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 8
rog
Please take a look.
11 years, 4 months ago (2012-11-27 20:04:43 UTC) #1
fwereade
LGTM https://codereview.appspot.com/6856105/diff/2001/container/container.go File container/container.go (left): https://codereview.appspot.com/6856105/diff/2001/container/container.go#oldcode49 container/container.go:49: } Nice :). https://codereview.appspot.com/6856105/diff/2001/state/open.go File state/open.go (right): https://codereview.appspot.com/6856105/diff/2001/state/open.go#newcode86 ...
11 years, 4 months ago (2012-11-28 09:10:13 UTC) #2
jameinel
LGTM. I have some comments, but it is just as likely me being unfamiliar with ...
11 years, 4 months ago (2012-11-28 09:50:40 UTC) #3
rog
Please take a look. https://codereview.appspot.com/6856105/diff/2001/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/6856105/diff/2001/environs/cloudinit/cloudinit.go#newcode167 environs/cloudinit/cloudinit.go:167: On 2012/11/28 09:50:40, jameinel wrote: ...
11 years, 4 months ago (2012-11-28 12:10:06 UTC) #4
niemeyer
This is brilliant. LGTM. https://codereview.appspot.com/6856105/diff/7001/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/6856105/diff/7001/environs/cloudinit/cloudinit.go#newcode226 environs/cloudinit/cloudinit.go:226: " --sslPEMKeyFile '" + serverPEMPath(cfg) ...
11 years, 4 months ago (2012-11-28 15:58:37 UTC) #5
rog
Please take a look. https://codereview.appspot.com/6856105/diff/7001/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/6856105/diff/7001/environs/cloudinit/cloudinit.go#newcode226 environs/cloudinit/cloudinit.go:226: " --sslPEMKeyFile '" + serverPEMPath(cfg) ...
11 years, 4 months ago (2012-11-28 18:08:05 UTC) #6
niemeyer
Please note that some trivials claimed "Done" weren't actually done. LGTM assuming they're done and ...
11 years, 4 months ago (2012-11-28 18:37:51 UTC) #7
rog
11 years, 4 months ago (2012-11-29 16:22:10 UTC) #8
*** Submitted:

various: use TLS

This enables TLS for everything.

R=fwereade, jameinel, niemeyer
CC=
https://codereview.appspot.com/6856105

https://codereview.appspot.com/6856105/diff/7001/environs/ec2/export_test.go
File environs/ec2/export_test.go (right):

https://codereview.appspot.com/6856105/diff/7001/environs/ec2/export_test.go#...
environs/ec2/export_test.go:105: var MgoPort = mgoPort
On 2012/11/28 18:37:51, niemeyer wrote:
> On 2012/11/28 18:08:05, rog wrote:
> > On 2012/11/28 15:58:37, niemeyer wrote:
> > > We shouldn't have to export this, or the value below actually.
> > 
> > Done.
> 
> Apparently not.

ha, i'd made the changes in a different branch!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b