Issue 6856060: state: consolidate entity watchers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6856060: state: consolidate entity watchers

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by fwereade

Modified:
11 years, 5 months ago

Reviewers:
mp+134934

Visibility:
Public.

Description

state: consolidate entity watchers https://code.launchpad.net/~fwereade/juju-core/consolidate-entity-watchers/+merge/134934 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: consolidate entity watchers #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -182 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/bootstrap.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/machine.go	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	state/machine_test.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	state/service_test.go	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	state/unit_test.go	View		3 chunks	+5 lines, -7 lines	0 comments	Download
M	state/watcher.go	View		2 chunks	+59 lines, -159 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Wow, lots of code going away so easily. Brilliant. LGTM

11 years, 5 months ago (2012-11-19 20:18:01 UTC) #2

niemeyer

Wow, lots of code going away so easily. Brilliant. LGTM

11 years, 5 months ago (2012-11-19 20:18:02 UTC) #3

fwereade

11 years, 5 months ago (2012-11-19 21:13:46 UTC) #4

*** Submitted:

state: consolidate entity watchers

R=niemeyer
CC=
https://codereview.appspot.com/6856060

Expand All Messages | Collapse All Messages