Issue 68560043: Trollius: call_exception_handler({'exc_info': True})

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68560043: Trollius: call_exception_handler({'exc_info': True})

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by haypo_gmail

Modified:
10 years, 2 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

Trollius: call_exception_handler({'exc_info': True})

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -30 lines)			Patch
M	asyncio/base_events.py	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	asyncio/events.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	asyncio/futures.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	asyncio/proactor_events.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	asyncio/selector_events.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	asyncio/transports.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	asyncio/unix_events.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	asyncio/windows_events.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/test_base_events.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/test_events.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_selector_events.py	View	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

yselivanov

Just to be clear, this is going to be committed only in Trollius, right?

10 years, 2 months ago (2014-02-25 14:41:00 UTC) #1

haypo_gmail

10 years, 2 months ago (2014-02-25 15:42:20 UTC) #2

On 2014/02/25 14:41:00, yselivanov wrote:
> Just to be clear, this is going to be committed only in Trollius, right?

I would simplify my job if it's also applied to Tulip and Python, but I wrote
the patch for Trollius.

Currently, default_exception_handler() rebuilds exc_info from the exception,
whereas it could get directly sys.exc_info(). What do you think?

Expand All Messages | Collapse All Messages