Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 6855107: code review 6855107: ssh: add functions for public keys in wire & auth keys ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by sledbetter
Modified:
8 years, 10 months ago
Reviewers:
CC:
agl1, dfc, golang-dev, bradfitz, agl
Visibility:
Public.

Description

ssh: add functions for public keys in wire & auth keys format. This allows easy import/export of public keys in the format expected by OpenSSH for authorized_keys files, as well as allowing comparisons with ServerConfig's PublickeyCallback. Fixes issue 3908.

Patch Set 1 #

Patch Set 2 : diff -r cf51e694ba75 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r cf51e694ba75 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r cf51e694ba75 https://code.google.com/p/go.crypto #

Total comments: 14

Patch Set 5 : diff -r cf51e694ba75 https://code.google.com/p/go.crypto #

Total comments: 13

Patch Set 6 : diff -r b2b2ae1f5140 https://code.google.com/p/go.crypto #

Total comments: 4

Patch Set 7 : diff -r b2b2ae1f5140 https://code.google.com/p/go.crypto #

Patch Set 8 : diff -r b2b2ae1f5140 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -0 lines) Patch
M ssh/keys.go View 1 2 3 4 5 6 7 2 chunks +184 lines, -0 lines 0 comments Download
A ssh/test/keys_test.go View 1 2 3 4 5 6 7 1 chunk +197 lines, -0 lines 0 comments Download

Messages

Total messages: 15
sledbetter
Hello golang-dev@googlegroups.com (cc: agl@chromium.org, dayveday@gmail.com), I'd like you to review this change to https://code.google.com/p/go.crypto
8 years, 11 months ago (2012-11-27 18:48:09 UTC) #1
sledbetter
Hello agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com (cc: agl@chromium.org, dayveday@gmail.com, golang-dev@googlegroups.com), Please take another look.
8 years, 11 months ago (2012-11-27 18:49:17 UTC) #2
agl1
https://codereview.appspot.com/6855107/diff/6001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/6855107/diff/6001/ssh/keys.go#newcode125 ssh/keys.go:125: // authorized_keys2 files for OpenSSH authorized_keys2 has been replaced ...
8 years, 11 months ago (2012-11-27 21:10:45 UTC) #3
sledbetter
https://codereview.appspot.com/6855107/diff/6001/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/6855107/diff/6001/ssh/keys.go#newcode125 ssh/keys.go:125: // authorized_keys2 files for OpenSSH On 2012/11/27 21:10:45, agl1 ...
8 years, 11 months ago (2012-11-28 02:09:02 UTC) #4
sledbetter
Hello agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com (cc: agl@chromium.org, golang-dev@googlegroups.com), Please take another look.
8 years, 11 months ago (2012-11-28 02:10:18 UTC) #5
agl1
https://codereview.appspot.com/6855107/diff/4004/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/6855107/diff/4004/ssh/keys.go#newcode124 ssh/keys.go:124: // ParseAuthorizedKeys parses a protocol 2 entry from an ...
8 years, 11 months ago (2012-11-29 21:15:22 UTC) #6
sledbetter
I cleaned up the whole CRLF parsing and added to and cleaned up the tests. ...
8 years, 11 months ago (2012-11-30 02:41:03 UTC) #7
agl1
Forgot to hg upload?
8 years, 11 months ago (2012-11-30 16:21:05 UTC) #8
sledbetter
Hello agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com (cc: agl@chromium.org, golang-dev@googlegroups.com), Please take another look.
8 years, 11 months ago (2012-11-30 17:54:17 UTC) #9
agl1
https://codereview.appspot.com/6855107/diff/3003/ssh/keys.go File ssh/keys.go (right): https://codereview.appspot.com/6855107/diff/3003/ssh/keys.go#newcode16 ssh/keys.go:16: // Keytypes supported by OpenSSH 1.5.9 1.5.9? Maybe 5.9? ...
8 years, 11 months ago (2012-11-30 22:36:45 UTC) #10
sledbetter
Pulled your changes in, caught one change needed in parser for backslashed quotes, added more ...
8 years, 10 months ago (2012-12-04 18:14:54 UTC) #11
agl1
Sorry, this got washed away by other stuff last week. There's a couple of things ...
8 years, 10 months ago (2012-12-10 16:11:52 UTC) #12
bradfitz
He's @google.com, so no CLA needed. On Mon, Dec 10, 2012 at 11:11 AM, <agl@golang.org> ...
8 years, 10 months ago (2012-12-10 16:27:20 UTC) #13
agl1
On Mon, Dec 10, 2012 at 11:21 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > He's @google.com, ...
8 years, 10 months ago (2012-12-10 17:21:17 UTC) #14
agl1
8 years, 10 months ago (2012-12-10 22:43:26 UTC) #15
*** Submitted as
https://code.google.com/p/go/source/detail?r=159cc2447982&repo=crypto ***

ssh: add functions for public keys in wire & auth keys format.

This allows easy import/export of public keys in the format
expected by OpenSSH for authorized_keys files, as well as
allowing comparisons with ServerConfig's PublickeyCallback.
Fixes issue 3908.

R=agl, dave, golang-dev, bradfitz
CC=agl, golang-dev
https://codereview.appspot.com/6855107

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b