iam: added group management methods

iam: added group management methods

Now iam package supports creating, deleting and listing groups.

https://code.launchpad.net/~franciscosouza/goamz/iam-group-management/+merge/136392

(do not edit description out of merge proposal)

[fss, 2012-11-27 12:40:41]

Please take a look.

[niemeyer, 2013-02-28 20:18:07]

This looks very good and ready for integration. Only a couple of comments
regarding docs.

LGTM. Just ping for integration after the doc changes please.

https://codereview.appspot.com/6855104/diff/1/iam/iam.go
File iam/iam.go (right):

https://codereview.appspot.com/6855104/diff/1/iam/iam.go#newcode161
iam/iam.go:161: // The path parameter is optional. Set it to "" and it will not
be sent to the
The method is looking good. The doc should say what is the path, though, and
what happens in terms of semantics when you don't provide one. Simply saying
it's optional means one has to go look at the docs to even know what it means.

https://codereview.appspot.com/6855104/diff/1/iam/iam.go#newcode190
iam/iam.go:190: // The parameter pathPrefix is optional. When set to "", Groups
will return all
// If pathPrefix is "", all groups are returned.

https://codereview.appspot.com/6855104/diff/1/iam/iamtest/server.go
File iam/iamtest/server.go (right):

https://codereview.appspot.com/6855104/diff/1/iam/iamtest/server.go#newcode248
iam/iamtest/server.go:248: Message:    fmt.Sprintf("The group with name %s
cannot be found.", name),
Is that the actual message reported by Amazon? If not, I suggest s/%s/%q/ here,
so the name is isolated from the sentence.

[fss, 2013-02-28 21:03:08]

Please take a look.

https://codereview.appspot.com/6855104/diff/1/iam/iam.go
File iam/iam.go (right):

https://codereview.appspot.com/6855104/diff/1/iam/iam.go#newcode161
iam/iam.go:161: // The path parameter is optional. Set it to "" and it will not
be sent to the
On 2013/02/28 20:18:08, niemeyer wrote:
> The method is looking good. The doc should say what is the path, though, and
> what happens in terms of semantics when you don't provide one. Simply saying
> it's optional means one has to go look at the docs to even know what it means.

Done.

I'm not sure if that is the best description. Paths are better explained here:
http://docs.aws.amazon.com/IAM/latest/UserGuide/Using_Identifiers.html (see also
ARN section).

https://codereview.appspot.com/6855104/diff/1/iam/iam.go#newcode190
iam/iam.go:190: // The parameter pathPrefix is optional. When set to "", Groups
will return all
On 2013/02/28 20:18:08, niemeyer wrote:
> // If pathPrefix is "", all groups are returned.

Done.

https://codereview.appspot.com/6855104/diff/1/iam/iamtest/server.go
File iam/iamtest/server.go (right):

https://codereview.appspot.com/6855104/diff/1/iam/iamtest/server.go#newcode248
iam/iamtest/server.go:248: Message:    fmt.Sprintf("The group with name %s
cannot be found.", name),
On 2013/02/28 20:18:08, niemeyer wrote:
> Is that the actual message reported by Amazon? If not, I suggest s/%s/%q/
here,
> so the name is isolated from the sentence.

yes, that's the message :S. Should I use %q anyway?

[niemeyer, 2013-02-28 22:10:02]

Thanks for the changes.

https://codereview.appspot.com/6855104/diff/1/iam/iam.go
File iam/iam.go (right):

https://codereview.appspot.com/6855104/diff/1/iam/iam.go#newcode161
iam/iam.go:161: // The path parameter is optional. Set it to "" and it will not
be sent to the
On 2013/02/28 21:03:08, fss wrote:
> On 2013/02/28 20:18:08, niemeyer wrote:
> > The method is looking good. The doc should say what is the path, though, and
> > what happens in terms of semantics when you don't provide one. Simply saying
> > it's optional means one has to go look at the docs to even know what it
means.
> 
> Done.
>
> I'm not sure if that is the best description. Paths are better explained here:

It shouldn't say whether it's sent to the server or not, as that's not really
interesting. What's interesting is what happens with what I put in that
parameter, and what happens if we omit it. I'll submit the branch and fix it.

[niemeyer, 2013-02-28 22:14:11]

Sorry, I actually can't submit it, as there's a conflict with trunk. Can you
please merge trunk into the branch and propose again?

If you want to fix the path comment, just say something like:

// If path is unset ("") it defaults to "/".

Thanks.

[fss, 2013-03-01 02:20:17]

Please take a look.

[fss, 2013-03-01 02:21:52]

Please take a look.

[fss, 2013-03-01 02:34:08]

Please take a look.

[niemeyer, 2013-03-01 17:38:04]

*** Submitted:

iam: added group management methods

Now iam package supports creating, deleting and listing groups.

R=niemeyer
CC=
https://codereview.appspot.com/6855104