code review 6855080: runtime: regenerate defs-files for freebsd

runtime: regenerate defs-files for freebsd

[minux1, 2012-11-23 19:36:31]

https://codereview.appspot.com/6849096/ for FreeBSD/ARM.

[mikio, 2012-11-24 09:40:45]

On 2012/11/23 19:36:31, minux wrote:
> https://codereview.appspot.com/6849096/ for FreeBSD/ARM.

thx.

[mikio, 2012-11-24 10:31:04]

Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[jsing, 2012-11-24 13:49:02]

LGTM.

FTR which version of FreeBSD was this regenerated on?

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
File src/pkg/runtime/defs_freebsd_386.h (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
src/pkg/runtime/defs_freebsd_386.h:118: typedef	byte	Sigval[4];
This appears to be no longer used/required.

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
File src/pkg/runtime/defs_freebsd_amd64.h (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
src/pkg/runtime/defs_freebsd_amd64.h:120: typedef	byte	Sigval[8];
Ditto.

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
File src/pkg/runtime/defs_freebsd_arm.h (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
src/pkg/runtime/defs_freebsd_arm.h:118: typedef	byte	Sigval[4];
Ditto.

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/signal_freeb...
File src/pkg/runtime/signal_freebsd_arm.c (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/signal_freeb...
src/pkg/runtime/signal_freebsd_arm.c:10: #define r0	__gregs[0]
This could also be done in the same manner as used for NetBSD/386 (or a
combination of the two).

[minux1, 2012-11-24 16:44:51]

On 2012/11/24 13:49:02, jsing wrote:
> FTR which version of FreeBSD was this regenerated on?
The FreeBSD/ARM is generated on FreeBSD-10 CURRENT.
(the arm port only support FreeBSD 10.)

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/signal_freeb...
File src/pkg/runtime/signal_freebsd_arm.c (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/signal_freeb...
src/pkg/runtime/signal_freebsd_arm.c:10: #define r0	__gregs[0]
On 2012/11/24 13:49:02, jsing wrote:
> This could also be done in the same manner as used for NetBSD/386 (or a
> combination of the two).
NetBSD provides definitions for REG_XXX, but FreeBSD/arm doesn't
provide those macros. also, defining these macros here avoids
unnecessary duplication of __gregs at every use site.

[mikio, 2012-11-25 08:20:11]

amd64 and 386 files are generated on 9.0-RELEASE.
I'm fine w/ helper definitions in signal_freebsd_arm.c.

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
File src/pkg/runtime/defs_freebsd_386.h (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
src/pkg/runtime/defs_freebsd_386.h:118: typedef	byte	Sigval[4];
On 2012/11/24 13:49:02, jsing wrote:
> This appears to be no longer used/required.

Done.

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
File src/pkg/runtime/defs_freebsd_amd64.h (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
src/pkg/runtime/defs_freebsd_amd64.h:120: typedef	byte	Sigval[8];
On 2012/11/24 13:49:02, jsing wrote:
> Ditto.

Done.

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
File src/pkg/runtime/defs_freebsd_arm.h (right):

https://codereview.appspot.com/6855080/diff/5003/src/pkg/runtime/defs_freebsd...
src/pkg/runtime/defs_freebsd_arm.h:118: typedef	byte	Sigval[4];
On 2012/11/24 13:49:02, jsing wrote:
> Ditto.

Done.

[mikio, 2012-11-25 08:20:38]

Hello minux.ma@gmail.com, jsing@google.com (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2012-11-26 12:29:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=c200281fac50 ***

runtime: regenerate defs-files for freebsd

R=minux.ma, jsing
CC=golang-dev
http://codereview.appspot.com/6855080