Issue 6854129: code review 6854129: net: allow "" as a hint wildcard to Resolve{IP,UDP,TCP}Addr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6854129: code review 6854129: net: allow "" as a hint wildcard to Resolve{IP,UDP,TCP}Addr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by mikio

Modified:
12 years, 8 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

net: allow "" as a hint wildcard to Resolve{IP,UDP,TCP}Addr Also fixes comments on ResolveIPAddr. Fixes issue 4476.

Patch Set 1 #

Patch Set 2 : diff -r 87d3b86bcc68 https://code.google.com/p/go #

Patch Set 3 : diff -r 87d3b86bcc68 https://code.google.com/p/go #

Patch Set 4 : diff -r 87d3b86bcc68 https://code.google.com/p/go #

Patch Set 5 : diff -r 87d3b86bcc68 https://code.google.com/p/go #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	src/pkg/net/ipraw_test.go	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/net/iprawsock.go	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pkg/net/tcp_test.go	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/net/tcpsock.go	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/net/udp_test.go	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/net/udpsock.go	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello bradfitz@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 8 months ago (2012-12-01 03:13:42 UTC) #1

mikio

Hello bradfitz@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 8 months ago (2012-12-01 03:27:19 UTC) #2

bradfitz

LGTM Thanks for the comments... that's what I was going to ask for on the ...

12 years, 8 months ago (2012-12-01 05:16:33 UTC) #3

mikio

12 years, 8 months ago (2012-12-01 05:50:06 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=027d52134c62 ***

net: allow "" as a hint wildcard to Resolve{IP,UDP,TCP}Addr

Also fixes comments on ResolveIPAddr.

Fixes issue 4476.

R=bradfitz, golang-dev
CC=golang-dev
https://codereview.appspot.com/6854129

Expand All Messages | Collapse All Messages