cert: new package

cert: new package

This enables us to use the same logic for generating
the test server keys as we use live.

There's no significant change in the logic that's
moved from environs.Bootstrap.

https://code.launchpad.net/~rogpeppe/juju-core/171-cert-package/+merge/136497

Requires: https://code.launchpad.net/~rogpeppe/juju-core/165-mandatory-certs-2/+merge/136495

(do not edit description out of merge proposal)

[rog, 2012-11-27 19:28:16]

Please take a look.

[fwereade, 2012-11-28 09:03:11]

LGTM

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go
File cert/cert.go (right):

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode116
cert/cert.go:116: // for using by a server for an environment with the given
s/using/use/

https://codereview.appspot.com/6854107/diff/2001/cert/cert_test.go
File cert/cert_test.go (right):

https://codereview.appspot.com/6854107/diff/2001/cert/cert_test.go#newcode214
cert/cert_test.go:214: // recordongConn returns a connection which
s/dong/ding/

[niemeyer, 2012-11-28 13:51:55]

LGTM, assuming that nothing changed within these functions and the following
trivials:

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go
File cert/cert.go (right):

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode18
cert/cert.go:18: 
// ...

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode19
cert/cert.go:19: func ParseCertificate(certPEM []byte) (*x509.Certificate,
error) {
ParseCert, as below.

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode33
cert/cert.go:33: 
// ...

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode53
cert/cert.go:53: // valid with respect to the given CA certificate
It'd be nice to have all these doc lines closer to 70 columns.

[rog, 2012-11-28 14:06:17]

*** Submitted:

cert: new package

This enables us to use the same logic for generating
the test server keys as we use live.

There's no significant change in the logic that's
moved from environs.Bootstrap.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6854107

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go
File cert/cert.go (right):

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode18
cert/cert.go:18: 
On 2012/11/28 13:51:55, niemeyer wrote:
> // ...

Done.

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode19
cert/cert.go:19: func ParseCertificate(certPEM []byte) (*x509.Certificate,
error) {
On 2012/11/28 13:51:55, niemeyer wrote:
> ParseCert, as below.

Done.

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode53
cert/cert.go:53: // valid with respect to the given CA certificate
On 2012/11/28 13:51:55, niemeyer wrote:
> It'd be nice to have all these doc lines closer to 70 columns.

Done.

https://codereview.appspot.com/6854107/diff/2001/cert/cert.go#newcode116
cert/cert.go:116: // for using by a server for an environment with the given
On 2012/11/28 09:03:11, fwereade wrote:
> s/using/use/

Done.

https://codereview.appspot.com/6854107/diff/2001/cert/cert_test.go
File cert/cert_test.go (right):

https://codereview.appspot.com/6854107/diff/2001/cert/cert_test.go#newcode214
cert/cert_test.go:214: // recordongConn returns a connection which
On 2012/11/28 09:03:11, fwereade wrote:
> s/dong/ding/

Done
:-)