Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3029)

Issue 6854054: environs/cloudinit: add RootCertPEM

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by rog
Modified:
11 years, 5 months ago
Reviewers:
mp+134498, TheMue
Visibility:
Public.

Description

environs/cloudinit: add RootCertPEM Instances need to know the root CA certificate so that they can verify the server they're talking to. https://code.launchpad.net/~rogpeppe/juju-core/151-cloudinit-root-cert/+merge/134498 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/cloudinit: add RootCertPEM #

Patch Set 3 : environs/cloudinit: add RootCertPEM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 4 chunks +15 lines, -1 line 0 comments Download
M environs/cloudinit/cloudinit_test.go View 5 chunks +24 lines, -0 lines 0 comments Download
M environs/ec2/ec2.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 5 months ago (2012-11-15 16:36:14 UTC) #1
TheMue
LGTM
11 years, 5 months ago (2012-11-15 16:42:33 UTC) #2
rog
11 years, 5 months ago (2012-11-16 08:37:15 UTC) #3
On 2012/11/15 16:42:33, TheMue wrote:
> LGTM

i've put this back to WIP as i don't think it's right.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b