Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 6852055: code review 6852055: runtime/cgo: enable warnings and treat as errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by dfc
Modified:
2 years, 8 months ago
Reviewers:
CC:
minux1, iant, golang-dev
Visibility:
Public.

Description

runtime/cgo: enable warnings and treat as errors Enable warnings as errors during the cgo portion of runtime/cgo. iant requested that the list of flags match cmd/dist/build.c, but I would like to avoid the set of disabled warnings if possible. ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion requires: 6843061

Patch Set 1 #

Patch Set 2 : diff -r ceaa16504f36 https://code.google.com/p/go #

Patch Set 3 : diff -r 591fc8a0131a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f5b22a4df675 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f5b22a4df675 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/runtime/cgo/cgo.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9
minux1
tested on FreeBSD/amd64, NetBSD/amd64, OpenBSD/amd64. after applying CL 6843061, test also pass on windows/386, and ...
2 years, 8 months ago (2012-11-15 09:14:11 UTC) #1
dfc
Thank you for testing, 6843061 looks good, please hg mail it if you have not ...
2 years, 8 months ago (2012-11-15 09:46:16 UTC) #2
dfc
Hello minux.ma@gmail.com, iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
2 years, 8 months ago (2012-11-15 11:23:55 UTC) #3
minux1
LGTM. please update description about tested systems (or just delete that section). I wonder if ...
2 years, 8 months ago (2012-11-15 11:28:59 UTC) #4
dfc
On 2012/11/15 11:28:59, minux wrote: > LGTM. > > please update description about tested systems ...
2 years, 8 months ago (2012-11-15 11:39:15 UTC) #5
iant
LGTM
2 years, 8 months ago (2012-11-15 14:44:11 UTC) #6
iant
Thanks.
2 years, 8 months ago (2012-11-15 14:44:19 UTC) #7
dfc
On 2012/11/15 14:44:19, iant wrote: > Thanks. Thank you Ian. I will submit once https://codereview.appspot.com/6843061/ ...
2 years, 8 months ago (2012-11-15 23:01:39 UTC) #8
dfc
2 years, 8 months ago (2012-11-17 21:59:10 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=11094b97d92a ***

runtime/cgo: enable warnings and treat as errors

Enable warnings as errors during the cgo portion of runtime/cgo. iant requested
that the list of flags match cmd/dist/build.c, but I would like to avoid the set
of disabled warnings if possible.

ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion

requires: 6843061

R=minux.ma, iant
CC=golang-dev
http://codereview.appspot.com/6852055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld dd67088