Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(401)

Issue 6852055: code review 6852055: runtime/cgo: enable warnings and treat as errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by dfc
Modified:
1 year, 5 months ago
Reviewers:
CC:
minux, iant, golang-dev
Visibility:
Public.

Description

runtime/cgo: enable warnings and treat as errors

Enable warnings as errors during the cgo portion of runtime/cgo. iant requested
that the list of flags match cmd/dist/build.c, but I would like to avoid the set
of disabled warnings if possible.

ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion

requires: 6843061

Patch Set 1 #

Patch Set 2 : diff -r ceaa16504f36 https://code.google.com/p/go #

Patch Set 3 : diff -r 591fc8a0131a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f5b22a4df675 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f5b22a4df675 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/runtime/cgo/cgo.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9
minux
tested on FreeBSD/amd64, NetBSD/amd64, OpenBSD/amd64. after applying CL 6843061, test also pass on windows/386, and ...
1 year, 5 months ago #1
dfc
Thank you for testing, 6843061 looks good, please hg mail it if you have not ...
1 year, 5 months ago #2
dfc
Hello minux.ma@gmail.com, iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 5 months ago #3
minux
LGTM. please update description about tested systems (or just delete that section). I wonder if ...
1 year, 5 months ago #4
dfc
On 2012/11/15 11:28:59, minux wrote: > LGTM. > > please update description about tested systems ...
1 year, 5 months ago #5
iant
LGTM
1 year, 5 months ago #6
iant
Thanks.
1 year, 5 months ago #7
dfc
On 2012/11/15 14:44:19, iant wrote: > Thanks. Thank you Ian. I will submit once https://codereview.appspot.com/6843061/ ...
1 year, 5 months ago #8
dfc
1 year, 5 months ago #9
*** Submitted as http://code.google.com/p/go/source/detail?r=11094b97d92a ***

runtime/cgo: enable warnings and treat as errors

Enable warnings as errors during the cgo portion of runtime/cgo. iant requested
that the list of flags match cmd/dist/build.c, but I would like to avoid the set
of disabled warnings if possible.

ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion

requires: 6843061

R=minux.ma, iant
CC=golang-dev
http://codereview.appspot.com/6852055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5