code review 6852055: runtime/cgo: enable warnings and treat as errors

runtime/cgo: enable warnings and treat as errors

Enable warnings as errors during the cgo portion of runtime/cgo. iant requested that the list of flags match cmd/dist/build.c, but I would like to avoid the set of disabled warnings if possible.

ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion

requires: 6843061

[minux1, 2012-11-15 09:14:11]

tested on FreeBSD/amd64, NetBSD/amd64, OpenBSD/amd64.

after applying CL 6843061, test also pass on windows/386,
and windows/amd64.

[dfc, 2012-11-15 09:46:16]

Thank you for testing, 6843061 looks good, please hg mail it if you have not
done so already. 

On 15/11/2012, at 20:14, minux.ma@gmail.com wrote:

> tested on FreeBSD/amd64, NetBSD/amd64, OpenBSD/amd64.
> 
> after applying CL 6843061, test also pass on windows/386,
> and windows/amd64.
> 
> https://codereview.appspot.com/6852055/

[dfc, 2012-11-15 11:23:55]

Hello minux.ma@gmail.com, iant@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2012-11-15 11:28:59]

LGTM.

please update description about tested systems (or just delete
that section).

I wonder if we want to enforce -Wall and -Werror in all our
std. library cgo files.

[dfc, 2012-11-15 11:39:15]

On 2012/11/15 11:28:59, minux wrote:
> LGTM.
> 
> please update description about tested systems (or just delete
> that section).

Done, deleted

> I wonder if we want to enforce -Wall and -Werror in all our
> std. library cgo files.

I would +1 that given this uncovered a long festering bug, lets wait to see what
others have to say.

[iant, 2012-11-15 14:44:11]

LGTM

[iant, 2012-11-15 14:44:19]

Thanks.

[dfc, 2012-11-15 23:01:39]

On 2012/11/15 14:44:19, iant wrote:
> Thanks.

Thank you Ian. I will submit once https://codereview.appspot.com/6843061/ is
submitted.

[dfc, 2012-11-17 21:59:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=11094b97d92a ***

runtime/cgo: enable warnings and treat as errors

Enable warnings as errors during the cgo portion of runtime/cgo. iant requested
that the list of flags match cmd/dist/build.c, but I would like to avoid the set
of disabled warnings if possible.

ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion

requires: 6843061

R=minux.ma, iant
CC=golang-dev
http://codereview.appspot.com/6852055