Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 6851128: Chrome canary is doing the right thing, our test is breaking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by metaweta
Modified:
13 years, 6 months ago
Reviewers:
MarkM, kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

A test to check whether a frozen object's __proto__ property was mutable was returning a symptom in the case of correct behavior, namely silently ignoring the assignment. This corrects the symptom report to a simple "false".

Patch Set 1 #

Patch Set 2 : Chrome canary is doing the right thing, our test is breaking #

Patch Set 3 : Chrome canary is doing the right thing, our test is breaking #

Patch Set 4 : Chrome canary is doing the right thing, our test is breaking #

Patch Set 5 : Chrome canary is doing the right thing, our test is breaking #

Patch Set 6 : Chrome canary is doing the right thing, our test is breaking #

Patch Set 7 : Fixes new, less harmful breakage in Chrome canary #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M src/com/google/caja/ses/repairES5.js View 1 2 3 4 4 chunks +45 lines, -4 lines 2 comments Download

Messages

Total messages: 11
metaweta
13 years, 7 months ago (2012-11-30 00:53:23 UTC) #1
MarkM
This is wrong. For the first, the assigning code is strict. For the second, it ...
13 years, 6 months ago (2012-11-30 07:48:14 UTC) #2
metaweta
A test to check whether a frozen object's __proto__ property was mutable was returning a ...
13 years, 6 months ago (2012-12-03 19:19:33 UTC) #3
metaweta
A test to check whether a frozen object's __proto__ property was mutable was returning a ...
13 years, 6 months ago (2012-12-03 19:20:22 UTC) #4
metaweta
A test to check whether a frozen object's __proto__ property was mutable was returning a ...
13 years, 6 months ago (2012-12-03 19:25:52 UTC) #5
metaweta
A test to check whether a frozen object's __proto__ property was mutable was returning a ...
13 years, 6 months ago (2012-12-03 19:26:39 UTC) #6
metaweta
A test to check whether a frozen object's __proto__ property was mutable was returning a ...
13 years, 6 months ago (2012-12-03 19:28:36 UTC) #7
metaweta
A test to check whether a frozen object's __proto__ property was mutable was returning a ...
13 years, 6 months ago (2012-12-03 19:29:19 UTC) #8
metaweta
OK, please have another look.
13 years, 6 months ago (2012-12-03 19:31:25 UTC) #9
kpreid2
LGTM modulo comments https://codereview.appspot.com/6851128/diff/12002/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): https://codereview.appspot.com/6851128/diff/12002/src/com/google/caja/ses/repairES5.js#newcode1925 src/com/google/caja/ses/repairES5.js:1925: var isExtensible = Object.isExtensible; Shouldn't these ...
13 years, 6 months ago (2012-12-03 20:14:54 UTC) #10
MarkM
13 years, 6 months ago (2012-12-03 20:55:46 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b