Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 6851095: fix browser test driver (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by felix8a
Modified:
13 years, 6 months ago
Reviewers:
Jasvir, kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This fixes http://code.google.com/p/google-caja/issues/detail?id=1590 Webdriver communication with firefox 17 is kind of unreliable, and this unreliability seems to happen only when opening new firefox windows. I tried digging into why this was happening, but haven't been able to isolate the cause yet. Instead, this patch changes our browser test driver to just re-use one window. I think the difference between "navigate window to url x" and "open new window with url x" are not relevant to our test cases. This is also faster, and improves our chances of success testing other browsers. In the case where a browser test fails, this still opens a new window, so that the failing windows remain available for manual inspection. I'm also upgrading webdriver to 2.26.0. I'm also fixing an issue where stderr is closed prematurely. I'm also adding support for RemoteWebDriver and ChromeDriver. Chrome works but doesn't pass 100% yet. HtmlUnit doesn't work, no idea why yet. I haven't tried IE or iphone yet.

Patch Set 1 #

Patch Set 2 : fix browser test driver #

Total comments: 6

Patch Set 3 : fix browser test driver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -111 lines) Patch
M build.xml View 1 4 chunks +6 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/BrowserTestCase.java View 1 2 6 chunks +88 lines, -79 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-client-uri-rewriting.js View 1 2 3 chunks +9 lines, -12 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-container-overflow.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-external-script-guest.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/es53-test-guest.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/util/LocalServer.java View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
A tests/com/google/caja/util/ThisHostName.java View 1 1 chunk +71 lines, -0 lines 0 comments Download
M third_party/java/webdriver/VERSION View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/java/webdriver/selenium-server-standalone-2.25.0.jar View Binary file 0 comments Download
A third_party/java/webdriver/selenium-server-standalone-2.26.0.jar View Binary file 0 comments Download
third_party/java/webdriver/selenium-server-standalone-2.26.0.jar View 1 2 0 chunks +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
felix8a
13 years, 6 months ago (2012-11-22 10:11:12 UTC) #1
felix8a
New snapshot, includes all the changes to support Chrome driver and RemoteWebDriver.
13 years, 6 months ago (2012-11-22 18:00:58 UTC) #2
kpreid2
https://codereview.appspot.com/6851095/diff/3001/tests/com/google/caja/plugin/BrowserTestCase.java File tests/com/google/caja/plugin/BrowserTestCase.java (right): https://codereview.appspot.com/6851095/diff/3001/tests/com/google/caja/plugin/BrowserTestCase.java#newcode65 tests/com/google/caja/plugin/BrowserTestCase.java:65: * <dt>caja.test.thihostname</dt> typo https://codereview.appspot.com/6851095/diff/3001/tests/com/google/caja/plugin/BrowserTestCase.java#newcode170 tests/com/google/caja/plugin/BrowserTestCase.java:170: String page = "http://" ...
13 years, 6 months ago (2012-11-22 18:35:33 UTC) #3
felix8a
updated snapshot https://codereview.appspot.com/6851095/diff/3001/tests/com/google/caja/plugin/BrowserTestCase.java File tests/com/google/caja/plugin/BrowserTestCase.java (right): https://codereview.appspot.com/6851095/diff/3001/tests/com/google/caja/plugin/BrowserTestCase.java#newcode65 tests/com/google/caja/plugin/BrowserTestCase.java:65: * <dt>caja.test.thihostname</dt> On 2012/11/22 18:35:33, kpreid2 wrote: ...
13 years, 6 months ago (2012-11-22 19:10:38 UTC) #4
kpreid2
LGTM
13 years, 6 months ago (2012-11-23 17:17:32 UTC) #5
felix8a
13 years, 6 months ago (2012-11-23 17:30:31 UTC) #6
@r5158
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b