Issue 6851057: environs/ec2: sensible public-bucket default

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6851057: environs/ec2: sensible public-bucket default (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dave

Modified:
12 years, 4 months ago

Reviewers:
mp+134619

Visibility:
Public.

Description

environs/ec2: sensible public-bucket default Given that we control the public bucket, it is arguably safe to hard code this. https://code.launchpad.net/~dave-cheney/juju-core/049-environs-ec2-public-bucket-sensible-default/+merge/134619 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: sensible public-bucket default #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/config.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/config_test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2012/11/16 08:07:35, dfc wrote: > Please take a look. LGTM

12 years, 4 months ago (2012-11-16 09:22:41 UTC) #2

dave_cheney.net

12 years, 4 months ago (2012-11-19 08:00:48 UTC) #4

*** Submitted:

environs/ec2: sensible public-bucket default

Given that we control the public bucket, it is arguably safe to hard code this.

R=
CC=
https://codereview.appspot.com/6851057

Expand All Messages | Collapse All Messages