Issue 6851043: environs/jujutest: further refinement

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6851043: environs/jujutest: further refinement

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rog

Modified:
11 years, 5 months ago

Reviewers:
mp+134080

Visibility:
Public.

Description

environs/jujutest: further refinement We change to use attributes rather than config.Config. This enables us to have configuration values drawn from an environment set up for the test, for instance from a faked-up home directory. https://code.launchpad.net/~rogpeppe/juju-core/142-jujutest-attrs/+merge/134080 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/jujutest: further refinement #

Patch Set 3 : environs/jujutest: further refinement #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -31 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs_test.go	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	environs/ec2/live_test.go	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	environs/ec2/local_test.go	View	4 chunks	+3 lines, -8 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/jujutest/tests.go	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

11 years, 5 months ago (2012-11-13 16:01:21 UTC) #4

*** Submitted:

environs/jujutest: further refinement

We change to use attributes rather than config.Config.
This enables us to have configuration values drawn from an environment
set up for the test, for instance from a faked-up home directory.

R=fwereade, TheMue
CC=
https://codereview.appspot.com/6851043

Expand All Messages | Collapse All Messages