code review 6850130: exp/gotype: added many more tests

exp/gotype: added many more tests

gotype can now handle much of the standard library.

- marked packages which have type checker issues
- this CL depends on CL 6846131

[gri, 2012-12-01 01:25:07]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gri, 2012-12-05 06:47:24]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-12-06 05:49:33]

LGTM

very nice

https://codereview.appspot.com/6850130/diff/21001/src/pkg/exp/gotype/gotype_t...
File src/pkg/exp/gotype/gotype_test.go (right):

https://codereview.appspot.com/6850130/diff/21001/src/pkg/exp/gotype/gotype_t...
src/pkg/exp/gotype/gotype_test.go:19: if suffix := ".go";
strings.HasSuffix(path, suffix) {
".go" seems easier to type than suffix but okay. :-)

[gri, 2012-12-06 17:09:29]

https://codereview.appspot.com/6850130/diff/21001/src/pkg/exp/gotype/gotype_t...
File src/pkg/exp/gotype/gotype_test.go (right):

https://codereview.appspot.com/6850130/diff/21001/src/pkg/exp/gotype/gotype_t...
src/pkg/exp/gotype/gotype_test.go:19: if suffix := ".go";
strings.HasSuffix(path, suffix) {
On 2012/12/06 05:49:33, rsc wrote:
> ".go" seems easier to type than suffix but okay. :-)

yeah - the only reason was that I am using suffix again 4 lines down. but yes,
it's unlikely that the suffix value will change anytime soon...

[gri, 2012-12-06 17:24:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=992bfc985165 ***

exp/gotype: added many more tests

gotype can now handle much of the standard library.

- marked packages which have type checker issues
- this CL depends on CL 6846131

R=rsc
CC=golang-dev
https://codereview.appspot.com/6850130