Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 6850070: code review 6850070: net: add unit tests for read/write deadlines (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dvyukov
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev, bradfitz, dfc
Visibility:
Public.

Description

net: add unit tests for read/write deadlines The tests verify that deadlines are "persistent", read/write deadlines do not interfere, can be reset, read deadline can be set with both SetDeadline() and SetReadDeadline(), etc.

Patch Set 1 #

Patch Set 2 : diff -r bbc0024af4a4 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r bbc0024af4a4 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r bbc0024af4a4 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 6

Patch Set 5 : diff -r f2755950769b https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 15

Patch Set 6 : diff -r f2755950769b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r f2755950769b https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 8 : diff -r 9764a39320d8 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 9764a39320d8 https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r 9764a39320d8 https://go.googlecode.com/hg/ #

Patch Set 11 : diff -r 9764a39320d8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -1 line) Patch
M src/pkg/net/timeout_test.go View 1 2 3 4 5 6 7 8 9 2 chunks +146 lines, -1 line 0 comments Download

Messages

Total messages: 12
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 7 months ago (2012-11-18 14:42:08 UTC) #1
bradfitz
https://codereview.appspot.com/6850070/diff/7001/src/pkg/net/timeout_test.go File src/pkg/net/timeout_test.go (right): https://codereview.appspot.com/6850070/diff/7001/src/pkg/net/timeout_test.go#newcode26 src/pkg/net/timeout_test.go:26: tl.SetDeadline(time.Now()) time.Now().Add(-1 * time.Second) to be clear? https://codereview.appspot.com/6850070/diff/7001/src/pkg/net/timeout_test.go#newcode49 src/pkg/net/timeout_test.go:49: ...
9 years, 7 months ago (2012-11-20 02:05:36 UTC) #2
dvyukov
On 2012/11/20 02:05:36, bradfitz wrote: > https://codereview.appspot.com/6850070/diff/7001/src/pkg/net/timeout_test.go > File src/pkg/net/timeout_test.go (right): > > https://codereview.appspot.com/6850070/diff/7001/src/pkg/net/timeout_test.go#newcode26 > ...
9 years, 7 months ago (2012-11-22 09:22:30 UTC) #3
dfc
Thank you for this proposal, some comments attached. https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go File src/pkg/net/timeout_test.go (right): https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode21 src/pkg/net/timeout_test.go:21: ln, ...
9 years, 7 months ago (2012-11-22 13:05:22 UTC) #4
dvyukov
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go File src/pkg/net/timeout_test.go (right): https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode21 src/pkg/net/timeout_test.go:21: ln, err := Listen("tcp", "127.0.0.1:0") On 2012/11/22 13:05:22, dfc ...
9 years, 7 months ago (2012-11-22 13:15:59 UTC) #5
dfc
https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go File src/pkg/net/timeout_test.go (right): https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode21 src/pkg/net/timeout_test.go:21: ln, err := Listen("tcp", "127.0.0.1:0") > What is the ...
9 years, 7 months ago (2012-11-22 13:21:21 UTC) #6
dvyukov
On 2012/11/22 13:21:21, dfc wrote: > https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go > File src/pkg/net/timeout_test.go (right): > > https://codereview.appspot.com/6850070/diff/1003/src/pkg/net/timeout_test.go#newcode21 > ...
9 years, 7 months ago (2012-11-23 07:02:58 UTC) #7
dfc
Thank you. LGTM, all tests pass on linux/arm
9 years, 7 months ago (2012-11-23 11:31:35 UTC) #8
dvyukov
Brad? On Fri, Nov 23, 2012 at 3:31 PM, <dave@cheney.net> wrote: > Thank you. LGTM, ...
9 years, 7 months ago (2012-11-23 11:46:59 UTC) #9
bradfitz
LGTM https://codereview.appspot.com/6850070/diff/1004/src/pkg/net/timeout_test.go File src/pkg/net/timeout_test.go (right): https://codereview.appspot.com/6850070/diff/1004/src/pkg/net/timeout_test.go#newcode21 src/pkg/net/timeout_test.go:21: ln, err := ListenTCP("tcp", &TCPAddr{IP: IP{127, 0, 0, ...
9 years, 7 months ago (2012-11-24 05:00:15 UTC) #10
dvyukov
On 2012/11/24 05:00:15, bradfitz wrote: > LGTM > > https://codereview.appspot.com/6850070/diff/1004/src/pkg/net/timeout_test.go > File src/pkg/net/timeout_test.go (right): > ...
9 years, 7 months ago (2012-11-25 09:27:14 UTC) #11
dvyukov
9 years, 7 months ago (2012-11-25 09:27:51 UTC) #12
*** Submitted as http://code.google.com/p/go/source/detail?r=d351a7cc9ca9 ***

net: add unit tests for read/write deadlines
The tests verify that deadlines are "persistent",
read/write deadlines do not interfere, can be reset,
read deadline can be set with both SetDeadline()
and SetReadDeadline(), etc.

R=golang-dev, bradfitz, dave
CC=golang-dev
http://codereview.appspot.com/6850070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b