Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 6850049: debug should not minimize third party js

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by thiago
Modified:
8 years, 5 months ago
Reviewers:
mp+134304
Visibility:
Public.

Description

debug should not minimize third party js If we are debugging third party javascript (app/assets/javscripts/...) and the file is not already minimized, make debug should not serve a minimized version. https://code.launchpad.net/~tveronezi/juju-gui/minimized-third-party-js/+merge/134304 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : debug should not minimize third party js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/modules.js View 1 chunk +2 lines, -10 lines 0 comments Download
M bin/merge-files View 1 chunk +7 lines, -2 lines 0 comments Download
M lib/server.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
thiago
Please take a look.
11 years, 6 months ago (2012-11-14 14:45:33 UTC) #1
gary.poster
Hi Thiago. Thank you very much for the quick changes. As we discussed, I have ...
11 years, 6 months ago (2012-11-14 17:15:51 UTC) #2
bac
Hi Thiago, Thanks for turning around this fix so quickly. I think it'll work nicely ...
11 years, 6 months ago (2012-11-14 18:54:26 UTC) #3
thiago
11 years, 6 months ago (2012-11-14 19:00:05 UTC) #4
*** Submitted:

debug should not minimize third party js

If we are debugging third party javascript (app/assets/javscripts/...) and the
file is not already minimized, make debug should not serve a minimized version.

R=gary.poster, bac
CC=
https://codereview.appspot.com/6850049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b