Issue 6849126: firewaller: skip flaky test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6849126: firewaller: skip flaky test

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by fwereade

Modified:
11 years, 5 months ago

Reviewers:
mp+137258

Visibility:
Public.

Description

firewaller: skip flaky test Note that the test itself is bascially fine; it exposes problems with the firewaller initialization, which need to be addressed, but which would respond well to expert attention. https://code.launchpad.net/~fwereade/juju-core/firewaller-skip-flaky-test/+merge/137258 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : firewaller: skip flaky test #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	worker/firewaller/firewaller_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

11 years, 5 months ago (2012-11-30 17:15:52 UTC) #4

*** Submitted:

firewaller: skip flaky test

Note that the test itself is bascially fine; it exposes problems with the
firewaller initialization, which need to be addressed, but which would
respond well to expert attention.

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6849126

Expand All Messages | Collapse All Messages