Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1357)

Issue 6849102: golxc: added networking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by TheMue
Modified:
6 years, 6 months ago
Reviewers:
mp+136220
Visibility:
Public.

Description

golxc: added networking Added the initial functionallity to start and stop the LXC networking, to retrieve vital data and to test if the networking is running. https://code.launchpad.net/~themue/golxc/003-added-network/+merge/136220 Requires: https://code.launchpad.net/~themue/golxc/002-added-configuration-reading/+merge/135166 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : golxc: added networking #

Total comments: 9

Patch Set 3 : golxc: added networking #

Total comments: 7

Patch Set 4 : golxc: added networking #

Total comments: 2

Patch Set 5 : golxc: added networking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -17 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M golxc.go View 1 2 3 4 5 chunks +20 lines, -12 lines 0 comments Download
M golxc_test.go View 1 2 3 4 4 chunks +58 lines, -5 lines 0 comments Download
A network.go View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 9
TheMue
Please take a look.
6 years, 9 months ago (2012-11-26 16:45:58 UTC) #1
dfc
https://codereview.appspot.com/6849102/diff/1/golxc.go File golxc.go (right): https://codereview.appspot.com/6849102/diff/1/golxc.go#newcode79 golxc.go:79: output, err := run("lxc-ls", "-1") /s/output/out/ https://codereview.appspot.com/6849102/diff/1/network.go File network.go ...
6 years, 8 months ago (2012-11-27 09:22:16 UTC) #2
TheMue
Please take a look. https://codereview.appspot.com/6849102/diff/1/golxc.go File golxc.go (right): https://codereview.appspot.com/6849102/diff/1/golxc.go#newcode79 golxc.go:79: output, err := run("lxc-ls", "-1") ...
6 years, 8 months ago (2012-11-27 10:03:39 UTC) #3
fwereade
I really think we should have tests that run without sudo -- so, just verifying ...
6 years, 6 months ago (2013-01-30 16:44:58 UTC) #4
TheMue
Please take a look. https://codereview.appspot.com/6849102/diff/5002/golxc.go File golxc.go (right): https://codereview.appspot.com/6849102/diff/5002/golxc.go#newcode311 golxc.go:311: out, err := cmd.CombinedOutput() On ...
6 years, 6 months ago (2013-01-31 17:14:22 UTC) #5
fwereade
Couple of minors https://codereview.appspot.com/6849102/diff/5002/golxc_test.go File golxc_test.go (right): https://codereview.appspot.com/6849102/diff/5002/golxc_test.go#newcode160 golxc_test.go:160: orig := golxc.SetLXCDefaultFile("/tmp/not-existing-exc-test") On 2013/01/31 17:14:22, ...
6 years, 6 months ago (2013-02-04 14:51:30 UTC) #6
TheMue
Please take a look. https://codereview.appspot.com/6849102/diff/11001/golxc.go File golxc.go (right): https://codereview.appspot.com/6849102/diff/11001/golxc.go#newcode318 golxc.go:318: } On 2013/02/04 14:51:30, fwereade ...
6 years, 6 months ago (2013-02-05 14:21:32 UTC) #7
fwereade
Sorry to keep on about these things :(. I'm ok to say LGTM in the ...
6 years, 6 months ago (2013-02-07 09:35:45 UTC) #8
TheMue
6 years, 6 months ago (2013-02-07 13:54:47 UTC) #9
*** Submitted:

golxc: added networking

Added the initial functionallity to start and stop the
LXC networking, to retrieve vital data and to test if
the networking is running.

R=dfc, fwereade
CC=
https://codereview.appspot.com/6849102

https://codereview.appspot.com/6849102/diff/18001/golxc_test.go
File golxc_test.go (right):

https://codereview.appspot.com/6849102/diff/18001/golxc_test.go#newcode173
golxc_test.go:173: // nonExistingPath returns a non-existing file path.
On 2013/02/07 09:35:45, fwereade wrote:
> I'm not sure how this solution is superior to a `filepath.Join(c.MkDir(),
> "foo")` at the call site.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b