Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 6849078: application hotkeys

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by thiago
Modified:
4 years, 12 months ago
Reviewers:
mp+131382
Visibility:
Public.

Description

application hotkeys The user can hit alt+e to open the environment view and alt+s to focus the charm search field. https://code.launchpad.net/~tveronezi/juju-gui/hotkeys/+merge/131382 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10

Patch Set 2 : application hotkeys #

Patch Set 3 : application hotkeys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -1 line) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 chunks +79 lines, -1 line 0 comments Download
M app/index.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/index.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/test_app_hotkeys.js View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 7
thiago
Please take a look.
8 years ago (2012-11-19 16:08:30 UTC) #1
matthew.scott
Thanks for the branch, Thiago. I have a few minors, but one regression that I'd ...
8 years ago (2012-11-19 18:36:51 UTC) #2
thiago
Thanks for your review, Matt! https://codereview.appspot.com/6849078/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/6849078/diff/1/app/app.js#newcode128 app/app.js:128: // F1...F12 or esc ...
8 years ago (2012-11-19 19:07:54 UTC) #3
matthew.scott
Thanks for the reply! +1 with the navigateTo change https://codereview.appspot.com/6849078/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/6849078/diff/1/app/app.js#newcode145 app/app.js:145: ...
8 years ago (2012-11-19 20:54:01 UTC) #4
benjamin.saller
With the navigate change this looks fine. I might remove the //XXX: comment at the ...
8 years ago (2012-11-20 13:26:32 UTC) #5
thiago
Thanks for your review Ben! []s, Thiago. https://codereview.appspot.com/6849078/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/6849078/diff/1/app/app.js#newcode557 app/app.js:557: if (next) ...
8 years ago (2012-11-20 14:53:59 UTC) #6
thiago
8 years ago (2012-11-20 15:41:27 UTC) #7
*** Submitted:

application hotkeys

The user can hit alt+e to open the environment view and alt+s to focus the 
charm search field.

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6849078
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b