Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 6849074: code review 6849074: go.talks/present/playground.js: auto scroll output (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by minux1
Modified:
9 years, 7 months ago
Reviewers:
CC:
adg, fss, golang-dev
Visibility:
Public.

Description

go.talks/present/playground.js: auto scroll output but only when the user already scrolls to the bottom.

Patch Set 1 #

Patch Set 2 : diff -r 232d341de375 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 232d341de375 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 232d341de375 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r 6adfd6981649 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M present/static/playground.js View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
9 years, 7 months ago (2012-11-18 21:18:41 UTC) #1
minux1
A good test case: http://127.0.0.1:3999/2012/goforc.slide#54 PS: scrollByLines is supported on Firefox, Safari and Chrome, but ...
9 years, 7 months ago (2012-11-18 21:25:00 UTC) #2
minux1
PTAL. Now I believe the Javascript is portable across browser.
9 years, 7 months ago (2012-11-20 18:15:56 UTC) #3
minux1
gentle ping?
9 years, 7 months ago (2012-11-26 18:02:47 UTC) #4
francesc
Hi, Could you host this somewhere where we can have a look on how it ...
9 years, 7 months ago (2012-11-26 18:13:23 UTC) #5
minux1
On Tue, Nov 27, 2012 at 2:13 AM, Francesc Campoy Flores <campoy@golang.org>wrote: > Could you ...
9 years, 7 months ago (2012-11-26 18:18:26 UTC) #6
rsc
Andrew should review this, but he's out this week. I think he'll be back next ...
9 years, 7 months ago (2012-11-26 20:54:46 UTC) #7
fss
On 2012/11/26 18:18:26, minux wrote: > On Tue, Nov 27, 2012 at 2:13 AM, Francesc ...
9 years, 7 months ago (2012-11-27 00:35:20 UTC) #8
adg
How portable is this?
9 years, 7 months ago (2012-11-30 12:35:33 UTC) #9
adg
LGTM if it works in Chrome, Firefox, and Safari.
9 years, 7 months ago (2012-11-30 12:36:06 UTC) #10
minux1
9 years, 7 months ago (2012-11-30 16:41:16 UTC) #11
*** Submitted as
https://code.google.com/p/go/source/detail?r=ed69caf364d5&repo=talks ***

go.talks/present/playground.js: auto scroll output
but only when the user already scrolls to the bottom.

R=adg, franciscossouza
CC=golang-dev
https://codereview.appspot.com/6849074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b