Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 6849045: code review 6849045: net, cmd/fix: add IPv6 scoped addressing zone to INET, ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by mikio
Modified:
10 years ago
Reviewers:
CC:
rsc, bradfitz, iant, golang-dev
Visibility:
Public.

Description

net, cmd/fix: add IPv6 scoped addressing zone to INET, INET6 address structs This CL starts to introduce IPv6 scoped addressing capability into the net package. The Public API changes are: +pkg net, type IPAddr struct, Zone string +pkg net, type IPNet struct, Zone string +pkg net, type TCPAddr struct, Zone string +pkg net, type UDPAddr struct, Zone string Update issue 4234.

Patch Set 1 : diff -r fc4e67d82024 https://code.google.com/p/go #

Patch Set 2 : diff -r fc4e67d82024 https://code.google.com/p/go #

Patch Set 3 : diff -r 40ba4d4e4672 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 40ba4d4e4672 https://code.google.com/p/go #

Patch Set 5 : diff -r 40ba4d4e4672 https://code.google.com/p/go #

Patch Set 6 : diff -r c4cc7dcc49cb https://code.google.com/p/go #

Total comments: 2

Patch Set 7 : diff -r c200281fac50 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -117 lines) Patch
src/cmd/fix/netipv6zone.go View 1 2 3 4 5 6 1 chunk +71 lines, -0 lines 0 comments Download
src/cmd/fix/netipv6zone_test.go View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
src/pkg/net/ip.go View 1 2 2 chunks +2 lines, -1 line 0 comments Download
src/pkg/net/ip_test.go View 4 chunks +45 lines, -45 lines 0 comments Download
src/pkg/net/iprawsock.go View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
src/pkg/net/iprawsock_plan9.go View 2 chunks +1 line, -3 lines 0 comments Download
src/pkg/net/iprawsock_posix.go View 1 2 7 chunks +10 lines, -12 lines 0 comments Download
src/pkg/net/ipsock.go View 1 2 3 4 5 2 chunks +22 lines, -1 line 0 comments Download
src/pkg/net/ipsock_plan9.go View 2 chunks +3 lines, -3 lines 0 comments Download
src/pkg/net/ipsock_posix.go View 1 2 4 chunks +12 lines, -9 lines 0 comments Download
src/pkg/net/multicast_posix_test.go View 1 chunk +18 lines, -18 lines 0 comments Download
src/pkg/net/tcpsock.go View 1 2 2 chunks +2 lines, -1 line 0 comments Download
src/pkg/net/tcpsock_posix.go View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
src/pkg/net/udpsock.go View 1 2 2 chunks +2 lines, -1 line 0 comments Download
src/pkg/net/udpsock_plan9.go View 2 chunks +1 line, -3 lines 0 comments Download
src/pkg/net/udpsock_posix.go View 1 2 9 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 12
mikio
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years ago (2012-11-13 12:10:48 UTC) #1
rsc
ZoneId sounds like ZoneName or ZoneString. Why not just Zone?
10 years ago (2012-11-13 17:34:36 UTC) #2
mikio
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years ago (2012-11-13 20:27:16 UTC) #3
mikio
On 2012/11/13 17:34:36, rsc wrote: > ZoneId sounds like ZoneName or ZoneString. Why not just ...
10 years ago (2012-11-13 20:27:40 UTC) #4
bradfitz
https://codereview.appspot.com/6849045/diff/7001/src/pkg/net/ip.go File src/pkg/net/ip.go (right): https://codereview.appspot.com/6849045/diff/7001/src/pkg/net/ip.go#newcode39 src/pkg/net/ip.go:39: Zone string // IPv6 scoped addressing zone can we ...
10 years ago (2012-11-13 20:39:08 UTC) #5
mikio
On 2012/11/13 20:39:08, bradfitz wrote: > can we get a gofix for this change? a ...
10 years ago (2012-11-13 20:52:30 UTC) #6
mikio
Hello rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years ago (2012-11-14 04:35:43 UTC) #7
mikio
PTAL CL 6816116 is now into 3 pieces. This CL, upcoming CL that do host/port ...
10 years ago (2012-11-15 03:02:40 UTC) #8
mikio
ping
10 years ago (2012-11-21 07:47:56 UTC) #9
iant
LGTM but please wait for rsc
10 years ago (2012-11-21 14:25:27 UTC) #10
rsc
LGTM https://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go File src/cmd/fix/netipv6zone.go (right): https://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go#newcode38 src/cmd/fix/netipv6zone.go:38: x, ok := se.X.(*ast.Ident) Please use isTopName(se.X, "net"). ...
10 years ago (2012-11-26 15:23:13 UTC) #11
mikio
10 years ago (2012-11-26 15:45:54 UTC) #12
*** Submitted as http://code.google.com/p/go/source/detail?r=61dc42e35948 ***

net, cmd/fix: add IPv6 scoped addressing zone to INET, INET6 address structs

This CL starts to introduce IPv6 scoped addressing capability
into the net package.

The Public API changes are:
+pkg net, type IPAddr struct, Zone string
+pkg net, type IPNet struct, Zone string
+pkg net, type TCPAddr struct, Zone string
+pkg net, type UDPAddr struct, Zone string

Update issue 4234.

R=rsc, bradfitz, iant
CC=golang-dev
http://codereview.appspot.com/6849045

http://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go
File src/cmd/fix/netipv6zone.go (right):

http://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go#ne...
src/cmd/fix/netipv6zone.go:38: x, ok := se.X.(*ast.Ident)
On 2012/11/26 15:23:15, rsc wrote:
> Please use isTopName(se.X, "net"). That will avoid misinterpreting local
> variables named net.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b