code review 6849045: net, cmd/fix: add IPv6 scoped addressing zone to INET, ...

net, cmd/fix: add IPv6 scoped addressing zone to INET, INET6 address structs

This CL starts to introduce IPv6 scoped addressing capability
into the net package.

The Public API changes are:
+pkg net, type IPAddr struct, Zone string
+pkg net, type IPNet struct, Zone string
+pkg net, type TCPAddr struct, Zone string
+pkg net, type UDPAddr struct, Zone string

Update issue 4234.

[mikio, 2012-11-13 12:10:48]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-11-13 17:34:36]

ZoneId sounds like ZoneName or ZoneString. Why not just Zone?

[mikio, 2012-11-13 20:27:16]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2012-11-13 20:27:40]

On 2012/11/13 17:34:36, rsc wrote:
> ZoneId sounds like ZoneName or ZoneString. Why not just Zone?

Nice, thx.

[bradfitz, 2012-11-13 20:39:08]

https://codereview.appspot.com/6849045/diff/7001/src/pkg/net/ip.go
File src/pkg/net/ip.go (right):

https://codereview.appspot.com/6849045/diff/7001/src/pkg/net/ip.go#newcode39
src/pkg/net/ip.go:39: Zone string // IPv6 scoped addressing zone
can we get a gofix for this change?  a lot of code exists (unfortunately) which
uses untagged struct literals for IPNet, assuming there are only two fields.

[mikio, 2012-11-13 20:52:30]

On 2012/11/13 20:39:08, bradfitz wrote:

> can we get a gofix for this change?  a lot of code exists (unfortunately)
which
> uses untagged struct literals for IPNet, assuming there are only two fields.

Will do.

[mikio, 2012-11-14 04:35:43]

Hello rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2012-11-15 03:02:40]

PTAL

CL 6816116 is now into 3 pieces.
This CL, upcoming CL that do host/port parser consolidation
and zone delimiter "%" parsing one.

https://codereview.appspot.com/6849045/diff/7001/src/pkg/net/ip.go
File src/pkg/net/ip.go (right):

https://codereview.appspot.com/6849045/diff/7001/src/pkg/net/ip.go#newcode39
src/pkg/net/ip.go:39: Zone string // IPv6 scoped addressing zone
On 2012/11/13 20:39:08, bradfitz wrote:
> can we get a gofix for this change?  a lot of code exists (unfortunately)
which
> uses untagged struct literals for IPNet, assuming there are only two fields.

Done.

[mikio, 2012-11-21 07:47:56]

ping

[iant, 2012-11-21 14:25:27]

LGTM but please wait for rsc

[rsc, 2012-11-26 15:23:13]

LGTM

https://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go
File src/cmd/fix/netipv6zone.go (right):

https://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go#n...
src/cmd/fix/netipv6zone.go:38: x, ok := se.X.(*ast.Ident)
Please use isTopName(se.X, "net"). That will avoid misinterpreting local
variables named net.

[mikio, 2012-11-26 15:45:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=61dc42e35948 ***

net, cmd/fix: add IPv6 scoped addressing zone to INET, INET6 address structs

This CL starts to introduce IPv6 scoped addressing capability
into the net package.

The Public API changes are:
+pkg net, type IPAddr struct, Zone string
+pkg net, type IPNet struct, Zone string
+pkg net, type TCPAddr struct, Zone string
+pkg net, type UDPAddr struct, Zone string

Update issue 4234.

R=rsc, bradfitz, iant
CC=golang-dev
http://codereview.appspot.com/6849045

http://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go
File src/cmd/fix/netipv6zone.go (right):

http://codereview.appspot.com/6849045/diff/4002/src/cmd/fix/netipv6zone.go#ne...
src/cmd/fix/netipv6zone.go:38: x, ok := se.X.(*ast.Ident)
On 2012/11/26 15:23:15, rsc wrote:
> Please use isTopName(se.X, "net"). That will avoid misinterpreting local
> variables named net.

Done.