Issue 6849044: environs/jujutest: simplify interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6849044: environs/jujutest: simplify interface

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+134056

Visibility:
Public.

Description

environs/jujutest: simplify interface The Environs/Name pair was a relic from when we couldn't open an environment from its attributes only. Using attributes makes it easier to have values that are programmatically generated, or bulky. https://code.launchpad.net/~rogpeppe/juju-core/142-jujutest-simplify/+merge/134056 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/jujutest: simplify interface #

Patch Set 3 : environs/jujutest: simplify interface #

Total comments: 2

Patch Set 4 : environs/jujutest: simplify interface #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -90 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs_test.go	View		2 chunks	+11 lines, -15 lines	0 comments	Download
M	environs/ec2/live_test.go	View		4 chunks	+27 lines, -32 lines	0 comments	Download
M	environs/ec2/local_test.go	View	1 2 3	2 chunks	+26 lines, -32 lines	0 comments	Download
M	environs/jujutest/livetests.go	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	environs/jujutest/tests.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jameinel

LGTM, seems a mostly mechanical change from using byte strings and reading them to using ...

11 years, 6 months ago (2012-11-13 09:58:52 UTC) #3

fwereade

LGTM https://codereview.appspot.com/6849044/diff/5001/environs/ec2/local_test.go File environs/ec2/local_test.go (right): https://codereview.appspot.com/6849044/diff/5001/environs/ec2/local_test.go#newcode27 environs/ec2/local_test.go:27: // N.B. Make sure the region we use ...

11 years, 6 months ago (2012-11-13 10:04:23 UTC) #4

TheMue

LGTM, only the comment movement like William suggested. https://codereview.appspot.com/6849044/diff/5001/environs/ec2/local_test.go File environs/ec2/local_test.go (right): https://codereview.appspot.com/6849044/diff/5001/environs/ec2/local_test.go#newcode27 environs/ec2/local_test.go:27: // ...

11 years, 6 months ago (2012-11-13 10:31:29 UTC) #5

rog

11 years, 6 months ago (2012-11-13 10:38:32 UTC) #6

*** Submitted:

environs/jujutest: simplify interface

The Environs/Name pair was a relic from when
we couldn't open an environment from its attributes
only. Using attributes makes it easier to
have values that are programmatically generated,
or bulky.

R=john.meinel, fwereade, TheMue
CC=
https://codereview.appspot.com/6849044

Expand All Messages | Collapse All Messages