Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1217)

Issue 6848052: cmd/juju: reenable bootstrap tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by rog
Modified:
11 years, 5 months ago
Reviewers:
mp+134356
Visibility:
Public.

Description

cmd/juju: reenable bootstrap tests. Looks like I forgot to add a call to gocheck.Suite in revision 669. Oops. https://code.launchpad.net/~rogpeppe/juju-core/147-reenable-bootstrap-tests/+merge/134356 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: reenable bootstrap tests. #

Patch Set 3 : cmd/juju: reenable bootstrap tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/bootstrap_test.go View 3 chunks +14 lines, -0 lines 0 comments Download
M cmd/juju/cmd_test.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
11 years, 5 months ago (2012-11-14 18:29:27 UTC) #1
rog
Please take a look.
11 years, 5 months ago (2012-11-14 18:30:16 UTC) #2
niemeyer
LGTM, and fail first. :)
11 years, 5 months ago (2012-11-15 00:39:01 UTC) #3
rog
11 years, 5 months ago (2012-11-15 08:21:18 UTC) #4
*** Submitted:

cmd/juju: reenable bootstrap tests.

Looks like I forgot to add a call to gocheck.Suite
in revision 669. Oops.

R=niemeyer
CC=
https://codereview.appspot.com/6848052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b