Issue 6847118: code review 6847118: goplay: does not work on IE.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847118: code review 6847118: goplay: does not work on IE.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by mattn

Modified:
11 years, 5 months ago

Reviewers:
minux1, 0xjnml, golang-dev, rsc

CC:
golang-dev

Visibility:
Public.

Description

goplay: does not work on IE.

Patch Set 1 #

Patch Set 2 : diff -r 1289e67dec66 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1289e67dec66 http://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -16 lines)			Patch
	M	misc/goplay/goplay.go	View	1	3 chunks	+54 lines, -16 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/

11 years, 5 months ago (2012-11-28 07:32:20 UTC) #1

0xjnml

On 2012/11/28 07:32:20, mattn wrote: > I'd like you to review this change to > ...

11 years, 5 months ago (2012-11-28 08:45:41 UTC) #2

mattn

> - Which/what issue does this fix? Current code contains some part for IE by ...

11 years, 5 months ago (2012-11-28 09:01:17 UTC) #3

minux1

personally, i do not care much about ie support given that we have many much ...

11 years, 5 months ago (2012-11-28 11:15:10 UTC) #4

rsc

Which version of IE is this fixing? It would be nice to support at least ...

11 years, 5 months ago (2012-11-28 14:05:12 UTC) #5

mattn

11 years, 5 months ago (2012-11-28 14:44:40 UTC) #6

Sorry for top post, I'm writing from mobile handy phone.

minux:
I'm thinking it's not difficult to support IE, golang.org does not
contains many HTML5 stuff or modern browser specific codes as worry
about.

russ:
I checked on IE8.

On 11/28/12, Russ Cox <rsc@golang.org> wrote:
> Which version of IE is this fixing? It would be nice to support at
> least the most recent one, assuming it is not too difficult. But I am
> not worried about 5-year-old IEs.
>
> Russ
>

-- 
- Yasuhiro Matsumoto

Expand All Messages | Collapse All Messages