Issue 6847114: all: make certificates mandatory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847114: all: make certificates mandatory

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rog

Modified:
12 years, 4 months ago

Reviewers:
mp+136495

Visibility:
Public.

Description

all: make certificates mandatory One more step on the road. https://code.launchpad.net/~rogpeppe/juju-core/165-mandatory-certs-2/+merge/136495 (do not edit description out of merge proposal)

Patch Set 2 : all: make certificates mandatory #

Total comments: 3

Patch Set 3 : all: make certificates mandatory #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -21 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View		3 chunks	+4 lines, -16 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View		4 chunks	+18 lines, -2 lines	0 comments	Download
M	environs/dummy/environs.go	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2	3 chunks	+10 lines, -1 line	0 comments	Download
M	juju/conn_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/testing/conn.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	state/open.go	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM with trivials: https://codereview.appspot.com/6847114/diff/2001/environs/ec2/ec2.go File environs/ec2/ec2.go (right): https://codereview.appspot.com/6847114/diff/2001/environs/ec2/ec2.go#newcode251 environs/ec2/ec2.go:251: return fmt.Errorf("environ config has no CA ...

12 years, 4 months ago (2012-11-27 19:35:23 UTC) #2

rog

12 years, 4 months ago (2012-11-27 19:44:20 UTC) #3

*** Submitted:

all: make certificates mandatory

One more step on the road.

R=niemeyer
CC=
https://codereview.appspot.com/6847114

Expand All Messages | Collapse All Messages