Issue 6847054: various: use juju.Bootstrap

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847054: various: use juju.Bootstrap

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rog

Modified:
11 years, 5 months ago

Reviewers:
mp+134437, niemeyer, TheMue

Visibility:
Public.

Description

various: use juju.Bootstrap https://code.launchpad.net/~rogpeppe/juju-core/146-cmd-bootstrap-use-juju/+merge/134437 Requires: https://code.launchpad.net/~rogpeppe/juju-core/145-juju-bootstrap/+merge/134339 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : various: use juju.Bootstrap #

Patch Set 3 : various: use juju.Bootstrap #

Patch Set 4 : various: use juju.Bootstrap #

Total comments: 2

Patch Set 5 : various: use juju.Bootstrap #

Patch Set 6 : various: use juju.Bootstrap #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -33 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/builddb/main.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/bootstrap_test.go	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	environs/ec2/live_test.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	environs/ec2/local_test.go	View	1 2 3 4	3 chunks	+4 lines, -7 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 2 3 4	3 chunks	+2 lines, -4 lines	0 comments	Download
M	environs/jujutest/tests.go	View	1 2 3 4	5 chunks	+9 lines, -9 lines	0 comments	Download
M	juju/conn_test.go	View	1 2 3 4	6 chunks	+6 lines, -6 lines	0 comments	Download
M	juju/testing/conn.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/cert.go	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6847054/diff/6001/cmd/juju/bootstrap_test.go File cmd/juju/bootstrap_test.go (right): https://codereview.appspot.com/6847054/diff/6001/cmd/juju/bootstrap_test.go#newcode58 cmd/juju/bootstrap_test.go:58: // Check that the root certificate has been ...

11 years, 5 months ago (2012-11-19 12:25:23 UTC) #3

rog

11 years, 5 months ago (2012-11-19 17:55:27 UTC) #4

*** Submitted:

various: use juju.Bootstrap

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6847054

Expand All Messages | Collapse All Messages