Issue 6847045: Really deprecate default-instance-type config key
DescriptionReally deprecate default-instance-type config key
When constraints were added, the idea was that default-instance-type
should no longer be needed and could be removed from everyone's
environments.yaml files. There were two problems with how this was
done however.
* The deprecation warning telling the user they need to remove
default-instance-type is printed when the key does not exist,
rather than when it does.
* The environments file still lists default-instance-type as one
of the required configuration keys, so juju will only work when
it is present.
This branch fixes those issues, so the advice about using constraints
instead may now actually get through.
What I'd also like to do, but this branch does not implement, is to
use the value from default-instance-type to act as a minimum required
instance type, given it's in quite wide use currently, and people are
always asking for m1.medium then being surpised when juju deploys on
an m1.tiny and runs out of memory.
https://code.launchpad.net/~gz/juju/no_default_instance_1069883/+merge/134168
(do not edit description out of merge proposal)
Patch Set 1 #
MessagesTotal messages: 2
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
