Issue 6846133: state: UnitsWatcher always reports dead units

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6846133: state: UnitsWatcher always reports dead units

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by fwereade

Modified:
11 years, 5 months ago

Reviewers:
mp+137192

Visibility:
Public.

Description

state: UnitsWatcher always reports dead units ...instead of skipping them in the initial event, which is not helpful behaviour. https://code.launchpad.net/~fwereade/juju-core/fix-units-watchers/+merge/137192 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : state: UnitsWatcher always reports dead units #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -18 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/export_test.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	state/unit_test.go	View		2 chunks	+10 lines, -5 lines	0 comments	Download
M	state/watcher.go	View	1	3 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM, just a trivial: https://codereview.appspot.com/6846133/diff/1/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6846133/diff/1/state/watcher.go#newcode826 state/watcher.go:826: // regardless of lifecycle status; ...

11 years, 5 months ago (2012-11-30 13:53:08 UTC) #2

fwereade

11 years, 5 months ago (2012-11-30 13:58:34 UTC) #3

*** Submitted:

state: UnitsWatcher always reports dead units

...instead of skipping them in the initial event, which is not helpful
behaviour.

R=niemeyer
CC=
https://codereview.appspot.com/6846133

https://codereview.appspot.com/6846133/diff/1/state/watcher.go
File state/watcher.go (right):

https://codereview.appspot.com/6846133/diff/1/state/watcher.go#newcode826
state/watcher.go:826: // regardless of lifecycle status; once a unit's Dead
status has been sent,
On 2012/11/30 13:53:08, niemeyer wrote:
> <niemeyer> fwereade: We don't send dead statuses, strictly speaking
> * niemeyer thinks
> <niemeyer> fwereade: "Once a unit observed as Dead has been reported"
> perhaps

Done.

Expand All Messages | Collapse All Messages