Issue 6846107: Remove "selective" contextmods.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6846107: Remove "selective" contextmods. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by dak

Modified:
11 years, 5 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Remove "selective" contextmods. This reverts those parts of commit 70365334614c31a82e9a3860c9eb9334cdc2879a that have been responsible for allowing context-mods to contain modifications restricted to certain context types. It also removes use of this feature from context-mod-from-music which is used for harvesting music into context modifications. As a result, any overrides in music used inside of context mods are interpreted without looking at their actually targeted contexts. It turned out that this "feature" offered more confusion than benefits.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -19 lines)			Patch
	M	lily/context-property.cc	View		1 chunk	+4 lines, -12 lines	0 comments	Download
	M	scm/lily-library.scm	View		2 chunks	+5 lines, -7 lines	0 comments	Download