Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 6846081: code review 6846081: net/http: fix TestChunkReaderAllocs failure when GOMAXP... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by minux1
Modified:
8 years, 11 months ago
Reviewers:
bradfitz, dfc, tegoor, albert.strasheim
CC:
albert.strasheim, bradfitz, dfc, golang-dev
Visibility:
Public.

Description

net/http, net/http/httputil: fix TestChunkReaderAllocs failure when GOMAXPROCS > 1

Patch Set 1 #

Patch Set 2 : diff -r 2524ef4a77b4 https://code.google.com/p/go #

Patch Set 3 : diff -r 2524ef4a77b4 https://code.google.com/p/go #

Patch Set 4 : diff -r 2524ef4a77b4 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/net/http/chunked_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/net/http/httputil/chunked_test.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10
minux1
Hello fullung@gmail.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2012-11-20 09:50:45 UTC) #1
minux1
Hello fullung@gmail.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2012-11-20 09:52:46 UTC) #2
dfc
LGTM, but wait for fullung to confirm.
9 years, 7 months ago (2012-11-20 09:53:47 UTC) #3
albert.strasheim
LGTM
9 years, 7 months ago (2012-11-20 10:01:35 UTC) #4
bradfitz
Needs to be done in both copies. http and httputil. Really, we should drop one ...
9 years, 7 months ago (2012-11-20 15:16:54 UTC) #5
minux1
On Tue, Nov 20, 2012 at 11:16 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > Needs to be ...
9 years, 7 months ago (2012-11-20 15:20:00 UTC) #6
bradfitz
LGTM Deleting a test file and z-ifying one of the impls can come layer. Thanks ...
9 years, 7 months ago (2012-11-20 15:27:00 UTC) #7
minux1
*** Submitted as http://code.google.com/p/go/source/detail?r=1315abc581ed *** net/http, net/http/httputil: fix TestChunkReaderAllocs failure when GOMAXPROCS > 1 R=fullung, ...
9 years, 7 months ago (2012-11-20 18:18:50 UTC) #8
tegoor_gmail.com
ok net 2.969s --- FAIL: TestChunkReaderAllocs (0.03 seconds) chunked_test.go:67: 14 mallocs; want <= 1 FAIL ...
8 years, 11 months ago (2013-07-31 23:53:25 UTC) #9
dfc
8 years, 11 months ago (2013-07-31 23:57:15 UTC) #10
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b