Remove ability to remove subordinate relations.

Remove ability to remove subordinate relations.

Attempting to remove a subordinate relation through the standard means will warn that it's not possible and not let the user remove the relation.

https://code.launchpad.net/~makyo/juju-gui/no-remove-sub-rels/+merge/134495

(do not edit description out of merge proposal)

[matthew.scott, 2012-11-15 15:57:16]

Please take a look.

[bac, 2012-11-15 20:27:29]

Looks good, except for the few things noted.  Thanks.

https://codereview.appspot.com/6846060/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6846060/diff/1/app/views/environment.js#newcod...
app/views/environment.js:456: .removeClass('yui5-button');
You discovered this typo when we chatted.

https://codereview.appspot.com/6846060/diff/1/test/test_environment_view.js
File test/test_environment_view.js (right):

https://codereview.appspot.com/6846060/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:410: panel.one('button').simulate('click');
How do we know this happened?

[matthew.scott, 2012-11-15 20:49:00]

Please take a look.

[matthew.scott, 2012-11-15 20:50:22]

Thanks, Brad.

https://codereview.appspot.com/6846060/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6846060/diff/1/app/views/environment.js#newcod...
app/views/environment.js:456: .removeClass('yui5-button');
On 2012/11/15 20:27:29, bac wrote:
> You discovered this typo when we chatted.

Done.

https://codereview.appspot.com/6846060/diff/1/test/test_environment_view.js
File test/test_environment_view.js (right):

https://codereview.appspot.com/6846060/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:410: panel.one('button').simulate('click');
On 2012/11/15 20:27:29, bac wrote:
> How do we know this happened?

Ah, good catch, assertion added.

[thiago, 2012-11-16 18:52:31]

Thanks Matt. It looks good.

I have just one comment, but it can be not related to this card.

[]s,
Thiago.

https://codereview.appspot.com/6846060/diff/4001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6846060/diff/4001/app/views/environment.js#new...
app/views/environment.js:1235: view.get('rmrelation_dialog').destroy();
During my tests I noticed that we dont do the same thing for the regular
relations. In other words, we keep adding a new div to the
"rmrelation-modal-panel" div every time we try to remove a regular relation.
Probably you could fix that here.

[matthew.scott, 2012-11-19 16:39:03]

*** Submitted:

Remove ability to remove subordinate relations.

Attempting to remove a subordinate relation through the standard means will warn
that it's not possible and not let the user remove the relation.

R=bac, thiago
CC=
https://codereview.appspot.com/6846060