Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 6846053: Charm search results upated styling

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by bac
Modified:
11 years, 5 months ago
Reviewers:
mp+134355
Visibility:
Public.

Description

Charm search results upated styling After the last changes Matt made some styling suggestions. His requirements are in the 'store_front_review.pdf' on the Google drive. One requirement was that the charm sections be a fixed height of 70px regardless of how long the charm summary is. This required we find a solution for truncating the text cleanly. The YUI gallery has 'gallery-ellipsis', which I've chosen to use. In order for it to work, the width of the element must be used, instead of using padding-right to cause wrapping. Once that was done, and the width of the float:right Deploy button was taken into account it all worked well. Matt asked for the filter drop down box but since it is not well spec'ed yet and not Ready To Code I decided to defer adding it at this time. https://code.launchpad.net/~bac/juju-gui/charm-search-style-2/+merge/134355 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Charm search results upated styling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 4 chunks +5 lines, -2 lines 0 comments Download
M bin/merge-files View 1 2 chunks +2 lines, -1 line 0 comments Download
M lib/views/stylesheet.less View 5 chunks +6 lines, -1 line 0 comments Download
M test/test_app.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
11 years, 5 months ago (2012-11-14 18:29:03 UTC) #1
matthew.scott
Nice and simple, works well, tests out. Looks good to me, thanks for the branch!
11 years, 5 months ago (2012-11-14 20:06:41 UTC) #2
teknico
Looks good to me. Right now only the charm description is shortened, and it is ...
11 years, 5 months ago (2012-11-15 12:08:18 UTC) #3
bac
On 2012/11/15 12:08:18, teknico wrote: > Looks good to me. > > Right now only ...
11 years, 5 months ago (2012-11-15 12:10:35 UTC) #4
bac
11 years, 5 months ago (2012-11-15 12:20:30 UTC) #5
*** Submitted:

Charm search results upated styling

After the last changes Matt made some styling suggestions.  His
requirements are in the 'store_front_review.pdf' on the Google drive.

One requirement was that the charm sections be a fixed height of 70px
regardless of how long the charm summary is.  This required we find a
solution for truncating the text cleanly.  The YUI gallery has
'gallery-ellipsis', which I've chosen to use.  In order for it to
work, the width of the element must be used, instead of using
padding-right to cause wrapping.  Once that was done, and the width of
the float:right Deploy button was taken into account it all worked
well.

Matt asked for the filter drop down box but since it is not well
spec'ed yet and not Ready To Code I decided to defer adding it at this
time.

R=matthew.scott, teknico
CC=
https://codereview.appspot.com/6846053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b