Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(162)

Issue 6845112: code review 6845112: cmd/gc: merge casep and casee labels (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by mssola
Modified:
12 years, 3 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net, rsc
Visibility:
Public.

Description

cmd/gc: merge casep and casee labels The code inside the casee and casep labels can perfectly be merged since they essentially do the same. The character to be stored where cp points is just the character contained by the c variable.

Patch Set 1 #

Patch Set 2 : diff -r a2a0638509dc https://code.google.com/p/go/ #

Patch Set 3 : diff -r a2a0638509dc https://code.google.com/p/go/ #

Patch Set 4 : diff -r a2a0638509dc https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M src/cmd/gc/lex.c View 1 4 chunks +7 lines, -30 lines 0 comments Download

Messages

Total messages: 7
mssola
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 3 months ago (2012-11-29 21:34:22 UTC) #1
dave_cheney.net
On 2012/11/29 21:34:22, mssola wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
12 years, 3 months ago (2012-11-30 00:14:53 UTC) #2
mssola
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 3 months ago (2012-11-30 07:46:19 UTC) #3
rsc
Looks good. Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright. Thanks. Russ
12 years, 3 months ago (2012-12-06 06:46:53 UTC) #4
mssola
Hi, according to http://golang.org/doc/contribute.html#copyright , since I'm not a committer (I'm not in the Go's ...
12 years, 3 months ago (2012-12-06 16:15:09 UTC) #5
rsc
LGTM
12 years, 3 months ago (2012-12-11 17:20:43 UTC) #6
rsc
12 years, 3 months ago (2012-12-11 17:23:13 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=0ce7955e8881 ***

cmd/gc: merge casep and casee labels

The code inside the casee and casep labels can perfectly be merged since
they essentially do the same. The character to be stored where cp points is
just the character contained by the c variable.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/6845112

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b