code review 6845083: doc/install-source.html: recent ARM and 386 updates

doc/install-source.html: recent ARM and 386 updates

[dave_cheney.net, 2013-02-09 21:57:15]

ping

[minux1, 2013-02-10 21:25:12]

Hello golang-dev@googlegroups.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[adg, 2013-02-10 22:26:10]

https://codereview.appspot.com/6845083/diff/11001/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/11001/doc/install-source.html#new...
doc/install-source.html:60: Supports Linux, FreeBSD and NetBSD binaries. Less
widely used than the other ports, but it's
s/it's/it is/

https://codereview.appspot.com/6845083/diff/11001/doc/install-source.html#new...
doc/install-source.html:61: working reliably.
indent this line too

https://codereview.appspot.com/6845083/diff/11001/doc/install-source.html#new...
doc/install-source.html:447: when you first run the Go executable on target
machine.
don't you need to set it before you build the go toolchain?

[minux1, 2013-02-10 22:33:41]

PTAL.

https://codereview.appspot.com/6845083/diff/11001/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/11001/doc/install-source.html#new...
doc/install-source.html:447: when you first run the Go executable on target
machine.
On 2013/02/10 22:26:11, adg wrote:
> don't you need to set it before you build the go toolchain?
the toolchain has default value for both GOARM (6) and GO386 (387).

if the binaries is compiled with a higher GOARM than necessary, when
running, it will show the correct GOARM to use and exit.

[dave_cheney.net, 2013-02-10 23:58:12]

Some minor comments, watch out for rev f9a328e8968c

https://codereview.appspot.com/6845083/diff/13002/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/13002/doc/install-source.html#new...
doc/install-source.html:60: Supports Linux, FreeBSD and NetBSD binaries. Less
widely used than the other ports, but it is
I would just say "Less widely used than the other ports".

https://codereview.appspot.com/6845083/diff/13002/doc/install-source.html#new...
doc/install-source.html:382: <td></td><td><code>plan9</code></td>
<td><code>amd64</code></td>
Is plan 9 officially supported ? I thought the plimsoll was an active builder on
the dashboard (note, speculation)

https://codereview.appspot.com/6845083/diff/13002/doc/install-source.html#new...
doc/install-source.html:417: <p><code>$GO386</code> (for 386 only, default is
auto detected if build natively, 387 if not)</p>
s/build/built/

https://codereview.appspot.com/6845083/diff/13002/doc/install-source.html#new...
doc/install-source.html:425: <p><code>$GOARM</code> (for arm only, default is
auto detected if build natively, 6 if not)</p>
same

https://codereview.appspot.com/6845083/diff/13002/doc/install-source.html#new...
doc/install-source.html:428: libraries should target. If you are compiling on
target system natively, its
s/libraries //

https://codereview.appspot.com/6845083/diff/13002/doc/install-source.html#new...
doc/install-source.html:436: <td></td><td><code>5</code></td> <td>use software
floating point</td> <td>when CPU doesn't have VFP</td>
have a VFP co-processor ?

[minux1, 2013-02-12 17:01:06]

PTAL.

[dave_cheney.net, 2013-02-12 22:27:32]

LGTM. Please wait for adg

Some minor nits below.

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:76: </p>
Either mention Plan9 here, or drop it's mention below, please.

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:369: <p><code>$GOHOSTOS</code> and
<code>$GOHOSTARCH</code></p>
Could you make this section <li />s

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:394: <p><code>$GO386</code> (for 386 only, default is
auto detected if built natively, 387 if not)</p>
(for <code>386</code> ... <code>387</code> ...

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:402: <p><code>$GOARM</code> (for arm only, default is
auto detected if built natively, 6 if not)</p>
<code>arm</code>

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:404: This sets the ARM floating point coprocessor
architecture version the run-time
co-processor (or make co-processor below unhypenated)

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:412: <td></td><td><code>5</code></td> <td>use software
floating point</td> <td>when CPU doesn't have VFP co-processor</td>
On the screen the final two cells run together (as they define the table width,
which is a bit jarring. Maybe use colspan=2, or twiddle the width of the
remaining columns to enforce a gap between the two.

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:415: <td></td><td><code>6</code></td> <td>use VFPv1
only</td> <td>default if cross compiling; ARM11 cores</td>
I thought it was VFPv2

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:422: If in doubt, leave this variable alone, and adjust
it as suggested
s/alone/unset/

possibly s/as suggested/if required/

[adg, 2013-02-13 03:40:02]

LGTM bar dcheney's comments

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:422: If in doubt, leave this variable alone, and adjust
it as suggested
s/alone/unset/ ?

[remyoudompheng, 2013-06-05 03:48:48]

ping?

I think this was never committed.

[adg, 2013-06-05 03:54:11]

The last round of comments were never addressed.

[minux1, 2013-06-07 10:20:56]

PTAL.

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/13003/doc/install-source.html#new...
doc/install-source.html:415: <td></td><td><code>6</code></td> <td>use VFPv1
only</td> <td>default if cross compiling; ARM11 cores</td>
On 2013/02/12 22:27:32, dfc wrote:
> I thought it was VFPv2
i think GOARM=6 don't use any VFPv2 specific features, so
in theory, we can run GOARM=6 binary on ARM9E+VFPv1 machines.

[r, 2013-06-07 15:24:26]

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:396: This controls the code generated by 8g to use
either 387 FPU (set to <code>387</code>) or
s/387 FPU/the 387 floating-point unit/

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:397: SSE2 (set to <code>sse2</code>) for floating point
computations.
s/SSE2/& instructions/

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:400: <li><code>GO386=387</code>: use x87 for floating
point operations, should support all x86 chips (Pentium MMX or better).
s/,/;/

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:400: <li><code>GO386=387</code>: use x87 for floating
point operations, should support all x86 chips (Pentium MMX or better).
s/better/later/ ?  better is an odd word here

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:401: <li><code>GO386=sse2</code>: use SSE2 for floating
point operations, has better performance than 387, but only available on Pentium
4/Opteron/Athlon 64 or better.
s/,/;/

again with better

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:404: <li><code>$GOARM</code> (for <code>arm</code> only,
default is auto detected if built natively, 6 if not)
s/,/;/

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:404: <li><code>$GOARM</code> (for <code>arm</code> only,
default is auto detected if built natively, 6 if not)
(for <code>arm</code> only; default is to detect automatically if built
natively, <code>6</code> if not)

i'm not sure why, but "natively" sounds wrong to me. maybe 'building on the
target processor'

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:407: should target. If you are compiling on target
system natively, its value will be auto detected.
"compiling on [the] target system natively" is redundant.  maybe s/natively//

https://codereview.appspot.com/6845083/diff/29001/doc/install-source.html#new...
doc/install-source.html:416: when you first run the Go executable on target
machine.
s/ on target machine// (where else will you run it?)

[minux1, 2013-06-09 15:11:23]

PTAL. All Rob's comments addressed.

[r, 2013-06-09 15:13:49]

LGTM

https://codereview.appspot.com/6845083/diff/32002/doc/install-source.html
File doc/install-source.html (right):

https://codereview.appspot.com/6845083/diff/32002/doc/install-source.html#new...
doc/install-source.html:393: <li><code>$GO386</code> (for <code>386</code> only,
default is auto detected
three times: s/auto detected/auto-detected/

https://codereview.appspot.com/6845083/diff/32002/doc/install-source.html#new...
doc/install-source.html:421: may contain further details regarding Go's ARM
support.
it does, doesn't it? so s/may contain/contains/

[minux1, 2013-06-09 15:16:03]

*** Submitted as https://code.google.com/p/go/source/detail?r=d2276901050c ***

doc/install-source.html: recent ARM and 386 updates

R=golang-dev, dave, adg, remyoudompheng, r
CC=golang-dev
https://codereview.appspot.com/6845083