state: add InstanceId type

state: add InstanceId type

...and use it where appropriate across the codebase.

https://code.launchpad.net/~fwereade/juju-core/state-instance-ids/+merge/136740

(do not edit description out of merge proposal)

[fwereade, 2012-11-28 18:00:44]

Please take a look.

[rog, 2012-11-28 18:11:54]

On 2012/11/28 18:00:44, fwereade wrote:
> Please take a look.

LGTM. The friction around goamz/ec2 is a little unfortunate but only to be
expected.

[niemeyer, 2012-11-28 18:17:17]

LGTM with a couple of trivials:

https://codereview.appspot.com/6844103/diff/1/state/machine.go
File state/machine.go (right):

https://codereview.appspot.com/6844103/diff/1/state/machine.go#newcode12
state/machine.go:12: // InstanceId values hold provider-specific instance
identifiers.
// An InstanceId is a provider-specific identifier associated with an
// instance (physical or virtual machine allocated in the provider).

https://codereview.appspot.com/6844103/diff/1/state/machine_test.go
File state/machine_test.go (right):

https://codereview.appspot.com/6844103/diff/1/state/machine_test.go#newcode97
state/machine_test.go:97: c.Assert(string(iid), Equals, "spaceship/0")
The casting is more useful on the other side, otherwise iid could well be a
plain string and that'd still work. Same below.

[fwereade, 2012-11-28 18:40:59]

*** Submitted:

state: add InstanceId type

...and use it where appropriate across the codebase.

R=rog, niemeyer
CC=
https://codereview.appspot.com/6844103

https://codereview.appspot.com/6844103/diff/1/state/machine.go
File state/machine.go (right):

https://codereview.appspot.com/6844103/diff/1/state/machine.go#newcode12
state/machine.go:12: // InstanceId values hold provider-specific instance
identifiers.
On 2012/11/28 18:17:17, niemeyer wrote:
> // An InstanceId is a provider-specific identifier associated with an
> // instance (physical or virtual machine allocated in the provider).

Done.

https://codereview.appspot.com/6844103/diff/1/state/machine_test.go
File state/machine_test.go (right):

https://codereview.appspot.com/6844103/diff/1/state/machine_test.go#newcode97
state/machine_test.go:97: c.Assert(string(iid), Equals, "spaceship/0")
On 2012/11/28 18:17:17, niemeyer wrote:
> The casting is more useful on the other side, otherwise iid could well be a
> plain string and that'd still work. Same below.

Done.