Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(431)

Issue 6844073: code review 6844073: crypto/tls: use 1/n-1 record splitting to protect again... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by ality
Modified:
9 years, 10 months ago
Reviewers:
CC:
agl1, golang-dev
Visibility:
Public.

Description

crypto/tls: use 1/n-1 record splitting to protect against BEAST This requires rebasing the block-mode test scripts. I used GnuTLS version 3.1.4.

Patch Set 1 #

Patch Set 2 : diff -r f2755950769b https://code.google.com/p/go/ #

Patch Set 3 : diff -r f2755950769b https://code.google.com/p/go/ #

Patch Set 4 : diff -r d2b512689ae1 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+543 lines, -391 lines) Patch
M src/pkg/crypto/tls/conn.go View 1 1 chunk +21 lines, -1 line 0 comments Download
M src/pkg/crypto/tls/handshake_client_test.go View 1 3 chunks +133 lines, -117 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 1 3 chunks +389 lines, -273 lines 0 comments Download

Messages

Total messages: 4
ality
Hello agl@chromium.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 10 months ago (2012-11-22 18:11:57 UTC) #1
ality
Changed reviewer: +agl1 -agl
9 years, 10 months ago (2012-11-22 18:16:59 UTC) #2
agl1
LGTM
9 years, 10 months ago (2012-11-22 21:12:16 UTC) #3
ality
9 years, 10 months ago (2012-11-26 18:57:21 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=1fc9db90a940 ***

crypto/tls: use 1/n-1 record splitting to protect against BEAST

This requires rebasing the block-mode test scripts.
I used GnuTLS version 3.1.4.

R=agl
CC=golang-dev
http://codereview.appspot.com/6844073
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b