Issue 6844073: code review 6844073: crypto/tls: use 1/n-1 record splitting to protect again...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6844073: code review 6844073: crypto/tls: use 1/n-1 record splitting to protect again... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by ality

Modified:
11 years, 5 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

crypto/tls: use 1/n-1 record splitting to protect against BEAST This requires rebasing the block-mode test scripts. I used GnuTLS version 3.1.4.

Patch Set 1 #

Patch Set 2 : diff -r f2755950769b https://code.google.com/p/go/ #

Patch Set 3 : diff -r f2755950769b https://code.google.com/p/go/ #

Patch Set 4 : diff -r d2b512689ae1 https://code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+543 lines, -391 lines)			Patch
M	src/pkg/crypto/tls/conn.go	View	1	1 chunk	+21 lines, -1 line	0 comments	Download
M	src/pkg/crypto/tls/handshake_client_test.go	View	1	3 chunks	+133 lines, -117 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server_test.go	View	1	3 chunks	+389 lines, -273 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ality

Hello agl@chromium.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 5 months ago (2012-11-22 18:11:57 UTC) #1

ality

11 years, 5 months ago (2012-11-26 18:57:21 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=1fc9db90a940 ***

crypto/tls: use 1/n-1 record splitting to protect against BEAST

This requires rebasing the block-mode test scripts.
I used GnuTLS version 3.1.4.

R=agl
CC=golang-dev
http://codereview.appspot.com/6844073

Expand All Messages | Collapse All Messages