Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 68440044: code review 68440044: crypto/cipher: fix AEAD.Open documentation nit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by bradfitz
Modified:
11 years, 3 months ago
Reviewers:
agl1, gobot
CC:
agl, agl1, golang-codereviews
Visibility:
Public.

Description

crypto/cipher: fix AEAD.Open documentation nit It mentioned true and false for error values. Instead, just don't mention the error semantics, as they match normal Go conventions (if error is non-nil, the other value is meaningless). We generally only document error values when they're interesting (where non-nil, non-nil is valid, or the error value can be certain known values or types). Fixes Issue 7464

Patch Set 1 #

Patch Set 2 : diff -r 6614172310c7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6614172310c7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6614172310c7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/pkg/crypto/cipher/gcm.go View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello agl@chromium.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2014-03-04 17:09:19 UTC) #1
agl1
LGTM
11 years, 3 months ago (2014-03-04 17:27:00 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=3982c3b1380b *** crypto/cipher: fix AEAD.Open documentation nit It mentioned true and false ...
11 years, 3 months ago (2014-03-04 17:58:56 UTC) #3
gobot
11 years, 3 months ago (2014-03-04 18:50:57 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64-race builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b