Issue 6843128: firewaller: use new style machine units watcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6843128: firewaller: use new style machine units watcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by fwereade

Modified:
11 years, 5 months ago

Reviewers:
mp+137176

Visibility:
Public.

Description

firewaller: use new style machine units watcher After https://code.launchpad.net/%7Earamh/juju-core/120-firewaller-new-watcher-units7/+merge/133269 Addresses comments made at https://codereview.appspot.com/6820112/ https://code.launchpad.net/~fwereade/juju-core/aramh-firewaller-changes/+merge/137176 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : firewaller: use new style machine units watcher #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -48 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/assign_test.go	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	state/unit.go	View	1 chunk	+13 lines, -4 lines	0 comments	Download
M	worker/firewaller/firewaller.go	View	4 chunks	+55 lines, -39 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

11 years, 5 months ago (2012-11-30 13:35:35 UTC) #3

*** Submitted:

firewaller: use new style machine units watcher

After
https://code.launchpad.net/%7Earamh/juju-core/120-firewaller-new-watcher-unit...

Addresses comments made at https://codereview.appspot.com/6820112/

R=niemeyer
CC=
https://codereview.appspot.com/6843128

Expand All Messages | Collapse All Messages