Add explicit std:: namespace to code from <cXYZ> includes.

Add explicit std:: namespace to code from <cXYZ> includes.

Some platforms seem to implicitly include the <XYZ.h> headers
which also add some types and functions (like strlen, size_t,...)
into the global namespace.

On other platforms though, this can result in compile errors, which
is noticeable in WebKit on e.g. QNX. See also: 
https://bugs.webkit.org/show_bug.cgi?id=95468

[milian.wolff, 2012-11-19 16:50:48]

Please review this in order to get https://bugs.webkit.org/show_bug.cgi?id=95468
sorted out.

[apatrick1, 2012-11-19 18:19:19]

Explicitly qualifying these names is a bit verbose. Someone suggested including
the C-style headers, like <string.h> instead of <cstring> in the referenced
WebKit bug. Would that work for you instead?

[dgkoch, 2012-11-19 18:30:03]

Please note that you must also sign the CLA and email me the required
information as described in
http://code.google.com/p/angleproject/wiki/ContributingCode before we accept 
patches.

[milian.wolff, 2012-11-19 18:44:30]

Hey there,

I can also try to adapt the patch to use the <foo.h> style includes instead of
<cfoo> if you prefer that. In the .cpp files I could alternatively also add a
"using namespace std;" - what would you prefer?

Regarding the CLA, KDAB (my employer, see change to AUTHORS) signed this, so
that should be enough, no? It was received by Daniel Berlin (dannyb).

Thanks and cheers, expect a revised patch from me later this week.

[Alok Priyadarshi, 2012-11-19 18:56:37]

I prefer keeping cFoo headers and do not mind std:: qualification. But if the
consensus is to use C headers, please follow this guide to properly sort the
includes:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

[dgkoch, 2012-11-19 19:04:03]

On 2012/11/19 18:44:30, milian.wolff wrote:
> Hey there,
> 
> I can also try to adapt the patch to use the <foo.h> style includes instead of
> <cfoo> if you prefer that. In the .cpp files I could alternatively also add a
> "using namespace std;" - what would you prefer?

Either explicit std:: qualifiers, or the other headers.  Definitely not "using
namespace std;". 

> Regarding the CLA, KDAB (my employer, see change to AUTHORS) signed this, so
> that should be enough, no? It was received by Daniel Berlin (dannyb).

Please also forward me the information listed in 3.2 on the ANGLE Wiki page.  I
don't have access to the Google CLAs and maintain a separate list for ANGLE.

Thanks,
Daniel

[milian.wolff, 2012-11-26 11:49:45]

On 2012/11/19 19:04:03, dgkoch wrote:
> On 2012/11/19 18:44:30, milian.wolff wrote:
> > Hey there,
> > 
> > I can also try to adapt the patch to use the <foo.h> style includes instead
of
> > <cfoo> if you prefer that. In the .cpp files I could alternatively also add
a
> > "using namespace std;" - what would you prefer?
> 
> Either explicit std:: qualifiers, or the other headers.  Definitely not "using
> namespace std;". 

Apparently replying by email doesn't work, so I'll add my comment here again: 

Considering that the patch supplied in this review request uses the explicit
std:: version, can we merge it as-is if both you and Alok are find with that?

I've send you the CLA information, is anything else required to get this fixed?

Cheers

[dgkoch, 2012-11-29 20:55:33]

> 
> I've send you the CLA information, is anything else required to get this
fixed?
> 
Committed in r1556.  Please close the issue.  Thanks!