Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 6842104: Ignore editor files.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by matthew.scott
Modified:
8 years ago
Reviewers:
mp+136484
Visibility:
Public.

Description

Ignore editor files. Watch functions will throw noisy errors on files not part of the distribution, making debugging watched files (templates, LESS stylesheet) difficult in `make debug`; an ifValidFile function was created to ignore these and slim down useless errors. Quick slack task. https://code.launchpad.net/~makyo/juju-gui/editor-files/+merge/136484 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Ignore editor files. #

Total comments: 5

Patch Set 3 : Ignore editor files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M lib/templates.js View 1 2 4 chunks +35 lines, -14 lines 0 comments Download

Messages

Total messages: 7
matthew.scott
Please take a look.
8 years ago (2012-11-27 18:27:24 UTC) #1
benji
Thanks for wanting to make the world a cleaner place. :) The better way to ...
8 years ago (2012-11-27 21:08:15 UTC) #2
gary.poster
+1. Thanks, Matt Gary
8 years ago (2012-11-27 21:09:10 UTC) #3
benji
On 2012/11/27 21:08:15, benji wrote: > Thanks for wanting to make the world a cleaner ...
8 years ago (2012-11-27 21:18:36 UTC) #4
matthew.scott
Please take a look.
8 years ago (2012-11-27 22:19:27 UTC) #5
gary.poster
Looks good to me. After changes requested, please land! Thank you. Gary === modified file ...
8 years ago (2012-11-27 22:45:07 UTC) #6
matthew.scott
8 years ago (2012-11-28 19:50:53 UTC) #7
*** Submitted:

Ignore editor files.

Watch functions will throw noisy errors on files not part of the distribution,
making debugging watched files (templates, LESS stylesheet) difficult in `make
debug`; an ifValidFile function was created to ignore these and slim down
useless errors.  Quick slack task.

R=benji, gary.poster
CC=
https://codereview.appspot.com/6842104
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b